[clang-tidy] update links to Google Code Style in docs

[omtcyf0]

Summary

Because of the recent Google Code shutdown links to the Google Code Style up there are no longer relevant.

[hokein]

docs/clang-tidy/checks/readability-named-parameter.rst

13 ↗

(On Diff #49039)

This should be in one line?

[omtcyf0]

docs/clang-tidy/checks/readability-named-parameter.rst

13 ↗

(On Diff #49039)

It is in html; breakline here is because of 80 chars per line limit.

[alexfh]

docs/clang-tidy/checks/readability-named-parameter.rst

13 ↗

(On Diff #49039)

HTML? This is rst, not html.

Anyway, the link shouldn't be split in two lines, otherwise it won't work. The 80-characters limit is not a hard limit, it can be violated, when you have long links or filenames.

Also, please create diffs with the full context when sending patches for review (http://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface).

[omtcyf0]

Removed the breakline.

[omtcyf0]

docs/clang-tidy/checks/readability-named-parameter.rst

13 ↗

(On Diff #49048)

It is rst. I meant generated HTML docs there.

IIRC rst is similar to markdown there -- the generated output won't have newline there unless there are 2 spaces at the end of line or a blank line.

[alexfh]

docs/clang-tidy/checks/readability-named-parameter.rst

13 ↗

(On Diff #49048)

One of the good properties of markdown and rst (though rst is worse in this regard) is that these formats are readable and usable as a plain text (unlike HTML, for example). Breaking the link makes the link unusable in the text mode (at least, not with vim in a terminal).

[alexfh]

LG. Thanks!

[alexfh]

Hajian, if you have no concerns, could you commit the patch? Thanks!

[omtcyf0]

docs/clang-tidy/checks/readability-named-parameter.rst

13 ↗

(On Diff #49048)

Okay, won't do that again :)

[hokein]

LGTM. I will commit the patch for you @omtcyf0.

[omtcyf0]

Thank you very much, @hokein!

[hokein]

docs/clang-tidy/checks/readability-named-parameter.rst

13 ↗

(On Diff #49048)

IIRC rst is similar to markdown there -- the generated output won't have newline there unless there are 2 spaces at the end of line or a blank line.

Indeed, the generated html will not have a new line, but the link will be broken.

[omtcyf0]

docs/clang-tidy/checks/readability-named-parameter.rst

13 ↗

(On Diff #49048)

Uh, you're right!

Sorry for arguing before, I thought it won't be; thanks for pointing out!

clang-tools-extra/trunk/clang-tidy/google/AvoidCStyleCastsCheck.h

 
 namespace clang {
 namespace tidy {
 namespace google {
 namespace readability {
 
 /// Finds usages of C-style casts.
 ///
-/// http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Casting#Casting
+/// https://google.github.io/styleguide/cppguide.html#Casting
 ///
 /// Corresponding cpplint.py check name: 'readability/casting'.
 ///
 /// This check is similar to `-Wold-style-cast`, but it suggests automated fixes
 /// in some cases. The reported locations should not be different from the
 /// ones generated by `-Wold-style-cast`.
 class AvoidCStyleCastsCheck : public ClangTidyCheck {
 public:

clang-tools-extra/trunk/clang-tidy/google/ExplicitConstructorCheck.h

 #include "../ClangTidy.h"
 
 namespace clang {
 namespace tidy {
 namespace google {
 
 /// Checks that all single-argument constructors are explicit.
 ///
-/// See http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Explicit_Constructors
+/// See https://google.github.io/styleguide/cppguide.html#Explicit_Constructors
 class ExplicitConstructorCheck : public ClangTidyCheck {
 public:
   ExplicitConstructorCheck(StringRef Name, ClangTidyContext *Context)
       : ClangTidyCheck(Name, Context) {}
   void registerMatchers(ast_matchers::MatchFinder *Finder) override;
   void check(const ast_matchers::MatchFinder::MatchResult &Result) override;
 };
 
 } // namespace google
 } // namespace tidy
 } // namespace clang
 
 #endif // LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_GOOGLE_EXPLICITCONSTRUCTORCHECK_H

clang-tools-extra/trunk/clang-tidy/google/OverloadedUnaryAndCheck.h

 
 namespace clang {
 namespace tidy {
 namespace google {
 namespace runtime {
 
 /// Finds overloads of unary `operator &`.
 ///
-/// http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Operator_Overloading#Operator_Overloading
+/// https://google.github.io/styleguide/cppguide.html#Operator_Overloading
 ///
 /// Corresponding cpplint.py check name: 'runtime/operator'.
 class OverloadedUnaryAndCheck : public ClangTidyCheck {
 public:
   OverloadedUnaryAndCheck(StringRef Name, ClangTidyContext *Context)
       : ClangTidyCheck(Name, Context) {}
   void registerMatchers(ast_matchers::MatchFinder *Finder) override;
   void check(const ast_matchers::MatchFinder::MatchResult &Result) override;
 };
 
 } // namespace runtime
 } // namespace google
 } // namespace tidy
 } // namespace clang
 
 #endif // LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_GOOGLE_OVERLOADEDUNARYANDCHECK_H

clang-tools-extra/trunk/clang-tidy/google/UnnamedNamespaceInHeaderCheck.h

 ///
 /// The check supports these options:
 ///   - `HeaderFileExtensions`: a comma-separated list of filename extensions of
 ///     header files (The filename extensions should not contain "." prefix).
 ///     "h,hh,hpp,hxx" by default.
 ///     For extension-less header files, using an empty string or leaving an
 ///     empty string between "," if there are other filename extensions.
 ///
-/// http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Namespaces#Namespaces
+/// https://google.github.io/styleguide/cppguide.html#Namespaces
 ///
 /// Corresponding cpplint.py check name: 'build/namespaces'.
 class UnnamedNamespaceInHeaderCheck : public ClangTidyCheck {
 public:
   UnnamedNamespaceInHeaderCheck(StringRef Name, ClangTidyContext *Context);
   void storeOptions(ClangTidyOptions::OptionMap &Opts) override;
   void registerMatchers(ast_matchers::MatchFinder *Finder) override;
   void check(const ast_matchers::MatchFinder::MatchResult &Result) override;

clang-tools-extra/trunk/clang-tidy/google/UsingNamespaceDirectiveCheck.h

 
 namespace clang {
 namespace tidy {
 namespace google {
 namespace build {
 
 /// Finds using namespace directives.
 ///
-/// http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Namespaces#Namespaces
+/// https://google.github.io/styleguide/cppguide.html#Namespaces
 ///
 /// The check implements the following rule of the Google C++ Style Guide:
 ///
 ///   You may not use a using-directive to make all names from a namespace
 ///   available.
 ///
 ///   \code
 ///     // Forbidden -- This pollutes the namespace.

clang-tools-extra/trunk/clang-tidy/readability/NamedParameterCheck.h

 namespace tidy {
 namespace readability {
 
 /// Find functions with unnamed arguments.
 ///
 /// The check implements the following rule originating in the Google C++ Style
 /// Guide:
 ///
-/// http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Function_Declarations_and_Definitions#Function_Declarations_and_Definitions
+/// https://google.github.io/styleguide/cppguide.html#Function_Declarations_and_Definitions
 ///
 /// All parameters should be named, with identical names in the declaration and
 /// implementation.
 ///
 /// Corresponding cpplint.py check name: 'readability/function'.
 class NamedParameterCheck : public ClangTidyCheck {
 public:
   NamedParameterCheck(StringRef Name, ClangTidyContext *Context)

clang-tools-extra/trunk/clang-tidy/readability/NamespaceCommentCheck.h

 namespace clang {
 namespace tidy {
 namespace readability {
 
 /// Checks that long namespaces have a closing comment.
 ///
 /// http://llvm.org/docs/CodingStandards.html#namespace-indentation
 ///
-/// http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Namespaces
+/// https://google.github.io/styleguide/cppguide.html#Namespaces
 class NamespaceCommentCheck : public ClangTidyCheck {
 public:
   NamespaceCommentCheck(StringRef Name, ClangTidyContext *Context);
   void registerMatchers(ast_matchers::MatchFinder *Finder) override;
   void check(const ast_matchers::MatchFinder::MatchResult &Result) override;
 
 private:
   void storeOptions(ClangTidyOptions::OptionMap &Options) override;

clang-tools-extra/trunk/docs/clang-tidy/checks/google-build-namespaces.rst

 .. title:: clang-tidy - google-build-namespaces
 
 google-build-namespaces
 =======================
 
 "cert-dcl59-cpp" redirects here as an alias for this check.
 
 Finds anonymous namespaces in headers.
 
-http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Namespaces#Namespaces
+https://google.github.io/styleguide/cppguide.html#Namespaces
 
 Corresponding cpplint.py check name: 'build/namespaces'.

clang-tools-extra/trunk/docs/clang-tidy/checks/google-build-using-namespace.rst

 .. title:: clang-tidy - google-build-using-namespace
 
 google-build-using-namespace
 ============================
 
 
 Finds using namespace directives.
 
-http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Namespaces#Namespaces
+https://google.github.io/styleguide/cppguide.html#Namespaces
 
 The check implements the following rule of the Google C++ Style Guide:
 
   You may not use a using-directive to make all names from a namespace
   available.
 
   .. code:: c++
 
     // Forbidden -- This pollutes the namespace.
     using namespace foo;
 
 Corresponding cpplint.py check name: ``build/namespaces``.

clang-tools-extra/trunk/docs/clang-tidy/checks/google-explicit-constructor.rst

 .. title:: clang-tidy - google-explicit-constructor
 
 google-explicit-constructor
 ===========================
 
 
 Checks that all single-argument constructors are explicit.
 
-See http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Explicit_Constructors
+See https://google.github.io/styleguide/cppguide.html#Explicit_Constructors

clang-tools-extra/trunk/docs/clang-tidy/checks/google-readability-casting.rst

 .. title:: clang-tidy - google-readability-casting
 
 google-readability-casting
 ==========================
 
 
 Finds usages of C-style casts.
 
-http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Casting#Casting
+https://google.github.io/styleguide/cppguide.html#Casting
 
 Corresponding cpplint.py check name: 'readability/casting'.
 
 This check is similar to ``-Wold-style-cast``, but it suggests automated fixes
 in some cases. The reported locations should not be different from the
 ones generated by ``-Wold-style-cast``.

clang-tools-extra/trunk/docs/clang-tidy/checks/google-readability-namespace-comments.rst

 .. title:: clang-tidy - google-readability-namespace-comments
 
 google-readability-namespace-comments
 =====================================
 
 
 Checks that long namespaces have a closing comment.
 
 http://llvm.org/docs/CodingStandards.html#namespace-indentation
 
-http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Namespaces
+https://google.github.io/styleguide/cppguide.html#Namespaces

clang-tools-extra/trunk/docs/clang-tidy/checks/google-runtime-operator.rst

 .. title:: clang-tidy - google-runtime-operator
 
 google-runtime-operator
 =======================
 
 
 Finds overloads of unary ``operator &``.
 
-http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Operator_Overloading#Operator_Overloading
+https://google.github.io/styleguide/cppguide.html#Operator_Overloading
 
 Corresponding cpplint.py check name: 'runtime/operator'.

clang-tools-extra/trunk/docs/clang-tidy/checks/llvm-namespace-comment.rst

 .. title:: clang-tidy - llvm-namespace-comment
 
 llvm-namespace-comment
 ======================
 
 
 Checks that long namespaces have a closing comment.
 
 http://llvm.org/docs/CodingStandards.html#namespace-indentation
 
-http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Namespaces
+https://google.github.io/styleguide/cppguide.html#Namespaces

clang-tools-extra/trunk/docs/clang-tidy/checks/readability-named-parameter.rst

 .. title:: clang-tidy - readability-named-parameter
 
 readability-named-parameter
 ===========================
 
 
 Find functions with unnamed arguments.
 
 The check implements the following rule originating in the Google C++ Style
 Guide:
 
-http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Function_Declarations_and_Definitions#Function_Declarations_and_Definitions
+https://google.github.io/styleguide/cppguide.html#Function_Declarations_and_Definitions
 
 All parameters should be named, with identical names in the declaration and
 implementation.
 
 Corresponding cpplint.py check name: 'readability/function'.