Page MenuHomePhabricator

Remove expectedFailureFreeBSD decorator
ClosedPublic

Authored by emaste on Feb 19 2016, 9:41 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

emaste updated this revision to Diff 48504.Feb 19 2016, 9:41 AM
emaste retitled this revision from to Remove expectedFailureFreeBSD decorator.
emaste updated this object.
emaste added a reviewer: zturner.
emaste added a subscriber: lldb-commits.
zturner added inline comments.Feb 19 2016, 10:14 AM
packages/Python/lldbsuite/test/expression_command/formatters/TestFormatters.py
26–27 ↗(On Diff #48504)

We have skipIfFreeBSD and then 2 instances of expectedFailureFreeBSD, the second of which is a duplicate of the skip. Maybe you could just delete the second line.

packages/Python/lldbsuite/test/functionalities/attach_resume/TestAttachResume.py
22 ↗(On Diff #48504)

Missing closing ] after 'freebsd'

emaste updated this revision to Diff 48529.Feb 19 2016, 11:26 AM

Address zturner feedback

zturner accepted this revision.Feb 19 2016, 11:27 AM
zturner edited edge metadata.
This revision is now accepted and ready to land.Feb 19 2016, 11:27 AM
emaste added inline comments.Feb 19 2016, 11:27 AM
packages/Python/lldbsuite/test/expression_command/formatters/TestFormatters.py
26–27 ↗(On Diff #48529)

Yes - I left two of them because they're different PRs, but didn't notice that the 2nd was a duplicate of the @skipIfFreeBSD. Thanks for catching it.

packages/Python/lldbsuite/test/functionalities/attach_resume/TestAttachResume.py
22 ↗(On Diff #48529)

thanks, not sure how that slipped through.

This revision was automatically updated to reflect the committed changes.