This is an archive of the discontinued LLVM Phabricator instance.

llvm-config: Don't check for "lib" prefix
AbandonedPublic

Authored by jvesely on Feb 17 2016, 4:12 PM.

Details

Reviewers
rnk
ehsan
Summary

GetComponentLibraryNameSlice() already checks that.

Using BUILD_SHARED_LIBS
AC->Library provides library name without prefix or suffix so this check would always fail.

Fixes libtool linking breakage in mesa since r206263: llvm-config: Add preliminary Windows support
--libs output should be different from --libfiles, the latter cannot be used with libtool

Diff Detail

Event Timeline

jvesely updated this revision to Diff 48257.Feb 17 2016, 4:12 PM
jvesely retitled this revision from to llvm-config: Don't check for "lib" prefix.
jvesely updated this object.
jvesely added reviewers: ehsan, rnk.
jvesely added a subscriber: llvm-commits.
ehsan edited edge metadata.Feb 22 2016, 12:47 PM

I think http://reviews.llvm.org/D17300 is a better solution for this. Can you please try that patch?

jvesely abandoned this revision.Feb 23 2016, 8:55 AM

I think http://reviews.llvm.org/D17300 is a better solution for this. Can you please try that patch?

D17300 works for me as well. abandoning this one.
thank you.