Also simplify some of the embedded C++ logic.
No functional changes.
Paths
| Differential D17354
Reformat NVPTXInstrInfo.td, and add additional comments. ClosedPublic Authored by jlebar on Feb 17 2016, 3:14 PM.
Details Summary Also simplify some of the embedded C++ logic. No functional changes.
Diff Detail
Event Timelinejlebar updated this object. Comment Actions What is the motivation for this? Is it reformatted with a tool? I'm not fundamentally opposed to such a change; I just want to understand the rationale since it touches a *lot* of code. Comment Actions
After finding the bug in D17315, I'm trawling through the tablegen files looking for other issues. I was going to have to carefully read the whole thing anyway, and figure I'm going to be more successful finding bugs if the code is consistently-formatted.
http://www.kinesis-ergo.com/shop/advantage-for-pc-mac/ :-p
If it helps, here's a diff that ignores all whitespace, including newlines. $ git diff --word-diff-regex=[^[:space:]] 7126dbe9c^..7126dbe9c | gist If you run this in your own terminal (fetch this branch: https://github.com/jlebar/llvm/tree/nvvm-reformat) it'll be all nice and color-coded. Comment Actions It would be helpful to get this in if we agree on it, otherwise I get to live in a rebase hell (admittedly of my own making) trying to land these other patches. Or otherwise I can drop this, and that will halve my rebase hell, but we'd lose I think some nontrivial cosmetic improvements. I can try to split out most of the whitespace changes from the non-ws changes if that would help. No promises -- I didn't split it up originally because I was afraid that even that would get me into rebase hell -- but I can try. jholewinski edited edge metadata. Comment ActionsSorry, I know I've been slow to respond recently... This looks fine. Thanks for taking the time to clean this up! This revision is now accepted and ready to land.Mar 1 2016, 4:54 AM Comment Actions
No worries, I know I've sent you a lot of code lately. :) Closed by commit rL262371: [NVPTX] Reformat NVPTXInstrInfo.td, and add additional comments. (authored by jlebar). · Explain WhyMar 1 2016, 11:28 AM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 49518 llvm/trunk/lib/Target/NVPTX/NVPTXInstrInfo.td
|