This is an archive of the discontinued LLVM Phabricator instance.

Add Qualcomm Kryo SchedMachineModel
AbandonedPublic

Authored by mcrosier on Feb 10 2016, 6:59 PM.

Details

Reviewers
cestes
apazos
Summary

Add Qualcomm Kryo SchedMachineModel.

Enable some beneficial Kryo CPU features.

Patch by Dave Estes.

Diff Detail

Repository
rL LLVM

Event Timeline

apazos updated this revision to Diff 47575.Feb 10 2016, 6:59 PM
apazos retitled this revision from to Add Qualcomm Kryo SchedMachineModel.
apazos updated this object.
apazos added reviewers: mcrosier, cestes.
apazos updated this object.Feb 10 2016, 7:00 PM

Hi Ana,

The first step should be to reformat the new .td file for 80 columns. Other than that, as with the M1 I think we have to defer to you for the particular values.

Does the schedcover.py output look sane? I didn't know about that wrinkle with the M1 but it certainly seems like something we want to check to be sure we won't get compilation failures.

Cheers.

Tim.

lib/Target/AArch64/AArch64Subtarget.h
157

This looks wrong to me.

t.p.northover added inline comments.Feb 10 2016, 7:11 PM
lib/Target/AArch64/AArch64SchedKryo.td
51–52

The bug numbers are probably OK given the limited scope of people with access to be able to work on this.

But what's this about obfuscation?

apazos updated this revision to Diff 47579.Feb 10 2016, 7:16 PM
apazos set the repository for this revision to rL LLVM.

Fixed missing ;

apazos updated this revision to Diff 47585.Feb 10 2016, 7:50 PM
apazos marked an inline comment as done.

Removed bug notes.

mcrosier commandeered this revision.Feb 11 2016, 6:36 AM
mcrosier edited reviewers, added: apazos; removed: mcrosier.

You seem to have lines in common with D17162, is that deprecated in favour of this one?

I think would be best if you merge them all into one, it's not a big change anyway, and gives a good atomic change to support kyro.

--renato

You seem to have lines in common with D17162, is that deprecated in favour of this one?

I do. I was trying to commits this in small parts and refactor the patches posted by Ana.

I think would be best if you merge them all into one, it's not a big change anyway, and gives a good atomic change to support kyro.

If you prefer one large monolithic patch, I'm happy to make that happen.

--renato

mcrosier abandoned this revision.Feb 11 2016, 12:56 PM

I'm going to merge this into one large patch.