This is an archive of the discontinued LLVM Phabricator instance.

[msan] Mark fork.cc unsupported on mips64 (and make it possible to do so)
AbandonedPublic

Authored by dsanders on Feb 9 2016, 3:11 PM.

Details

Reviewers
hans
samsonov
Summary

fork.cc currently hangs for mips64, preventing 'check-all' from finishing
in the 3.8 release.

We can't xfail it since that still runs the test, so we must mark it
'unsupported' instead. Unfortunately, the target triple that lit checks against
is the default target triple which in our case is different to the actual
target triple.

This patch resolves this by making '${target_arch}-arch' an available feature
for use in lit directives. We can then use that to correctly mark the test
'unsupported'. The reason for the '-arch' suffix is so that 'mips64' doesn't
also match 'mips64el' which currently passes this test.

Depends on D16855.

Diff Detail

Event Timeline

dsanders updated this revision to Diff 47379.Feb 9 2016, 3:11 PM
dsanders retitled this revision from to [msan] Mark fork.cc unsupported on mips64 (and make it possible to do so).
dsanders updated this object.
dsanders added reviewers: samsonov, hans.
dsanders added a subscriber: llvm-commits.
samsonov added inline comments.Feb 9 2016, 5:00 PM
test/msan/lit.cfg
29

Can this go to test/lit.common.cfg instead?

dsanders abandoned this revision.Jul 18 2019, 7:08 PM