19957 - OpenCL incorrectly accepts implicit address space conversion with ternary operator

[• ichesnokov]

Summary

Test cases moved to SemaOpenCL folder.

[• ichesnokov]

The BugZilla page: https://llvm.org/bugs/show_bug.cgi?id=19957

[• ichesnokov]

Please hold of working on this bug. Unit test have to be corrected.

[asl]

test/CodeGenOpenCL/ternary-implicit-casts-fail.cl

2 ↗

(On Diff #46275)

Don't do XFAIL tests - they will be "ok" regardless of the failure type. Make sure you're checking the exact error message, etc.

test/CodeGenOpenCL/ternary-implicit-casts-succ.cl

5 ↗

(On Diff #46275)

What we're checking here? If this is codegen test, then you need to check for generated IR. It looks like a sema bug / test.

[• ichesnokov]

test/CodeGenOpenCL/ternary-implicit-casts-fail.cl

2 ↗

(On Diff #46275)

Unable to use expected-error {{}}.
Compiler gives error: initializing 'local int *' with an expression of type 'void *' changes address space of pointer
Using expected-error {{initializing 'local int *' with an expression of type 'void *' changes address space of pointer}} does not work.
Thus I used XFAIL.

test/CodeGenOpenCL/ternary-implicit-casts-succ.cl

5 ↗

(On Diff #46275)

Here we checking assignment operator. Variable 'ptr' is in generic address space and should take both global and local values.
In previous "XFAIL" test there's assignment to "local ptr*" has to fail.

[• ichesnokov]

Anton, answers to your questions are in Diff 2 46275

[asl]

test/CodeGenOpenCL/ternary-implicit-casts-fail.cl

2 ↗

(On Diff #46275)

This is either bug in expected-error stuff (which I honestly doubt) or you did something wrong.

[• ichesnokov]

test/CodeGenOpenCL/ternary-implicit-casts-fail.cl

2 ↗

(On Diff #46275)

I'll send the patch to llvm-dev to find out what's the reason of expected-error fail.

[• ichesnokov]

BugZilla page: https://llvm.org/bugs/show_bug.cgi?id=19957.

I'll hold off working on this bug, until expected-result {{ }} question will be solved.

[• ichesnokov]

https://llvm.org/bugs/show_bug.cgi?id=19957

[• ichesnokov]

Please review and commit.
There's no patch, but only unit tests.

[• ichesnokov]

Please review and commit.
There's no patch, but only unit tests.

[• ichesnokov]

BugZilla page: https://llvm.org/bugs/show_bug.cgi?id=19957

[• ichesnokov]

Test cases moved to single file.
Please review and accept.

[• ichesnokov]

test/CodeGenOpenCL/ternary-implicit-casts-fail.cl

2 ↗

(On Diff #46275)

It was my error: I forgot add -verify parameter.

[Anastasia]

test/SemaOpenCL/ternary-implicit-casts.cl

6

Again, I am not quite clear about the purpose of this change.

We have similar testing in test/SemaOpenCL/address-spaces-conversions-cl2.0.cl.

However, the diagnostics, that Clang currently gives, seem wrong to me. We might need to investigate that.

[• ichesnokov]

test/SemaOpenCL/ternary-implicit-casts.cl

6

This test point is the ternary operator. It displays that ternary operator may return not only in different values, but also different address spaces. I do not see such check in address-spaces-conversions-cl2.0.cl.

[bader]

test/SemaOpenCL/ternary-implicit-casts.cl

10–11

Note that test doesn't specify OpenCL version. By default it's 1.0, so ptr points to private AS and it's illegal to cast pointers from different address spaces in OpenCL v1.x.

[• ichesnokov]

It looks like there's more todo to close this bug.
Let's go back to bug discussion at: https://llvm.org/bugs/show_bug.cgi?id=19957

[• ichesnokov]

test/SemaOpenCL/ternary-implicit-casts.cl

10–11

Let's discuss in https://llvm.org/bugs/show_bug.cgi?id=19957

[arsenm]

Is this still necessary? The bug is marked fixed

test/SemaOpenCL/ternary-implicit-casts.cl

+// RUN: %clang_cc1 %s -verify -pedantic -fsyntax-only
+
+kernel void implicit_cast_local(global int* gint, local int* lint, int cond)
+{
+  // will not compile, ptr is not generic but local
+  local int *ptr = cond ? gint : lint; // expected-warning {{pointer type mismatch ('__global int *' and '__local int *')}} expected-error {{initializing '__local int *' with an expression of type 'void *' changes address space of pointer}}
+}
+
+kernel void implicit_cast_generic(global int* gint, local int* lint, int cond) {
+  // will compile, ptr is generic and can accept global and local
+  int* ptr = cond ? gint : lint; // expected-warning {{pointer type mismatch ('__global int *' and '__local int *')}}
+}