This is an archive of the discontinued LLVM Phabricator instance.

[mips] Expansion of SC[D] for pre-r6
AcceptedPublic

Authored by obucina on Jan 28 2016, 1:18 AM.

Diff Detail

Event Timeline

obucina updated this revision to Diff 46245.Jan 28 2016, 1:18 AM
obucina retitled this revision from to [mips] Expansion of SC[D] for pre-r6.
obucina updated this object.
obucina added reviewers: dsanders, zoran.jovanovic.
obucina edited edge metadata.Jan 28 2016, 1:19 AM
obucina added a subscriber: llvm-commits.
vkalintiris edited edge metadata.Mar 21 2016, 9:40 AM

Hi Srdjan, can you rebase this because it doesn't apply cleanly?

obucina updated this revision to Diff 52814.Apr 6 2016, 9:34 AM
obucina edited edge metadata.

Rebased.

Vasilis, patch is rebased. Please be faster with reviewing so that outdating does not happens again.

vkalintiris accepted this revision.Apr 8 2016, 9:39 AM
vkalintiris edited edge metadata.

LGTM with one comment inline.

lib/Target/Mips/AsmParser/MipsAsmParser.cpp
2630–2647

It's not necessary for this patch, but if we use IsSC with the ternary operator ?:, we could simplify the code and avoid the duplication by picking the correct operand number that we want to use.

This revision is now accepted and ready to land.Apr 8 2016, 9:39 AM
obucina updated this revision to Diff 53388.Apr 12 2016, 5:24 AM
obucina edited edge metadata.

Changes in accordance to last review (if replaced with ternary operator).

obucina marked an inline comment as done.Apr 12 2016, 5:25 AM

Looks like patch was not committed.

dsanders resigned from this revision.Jul 18 2019, 7:02 PM