test suite: fix exception if --platform-name is specified that doesn't start with "remote-"

[tfiala]

Summary

As would happen if the test suite was given "--platform-name ios-simulator".

Also removes the expected timeouts for Darwin as these are now handled by reruns.

[tfiala]

Hi Ed - not sure if freebsd still needs the set of expected timeout tests. If you were to run with --rerun-all-issues, then all tests are eligible for a rerun on the first failure/timeout/error/whatever. (expected failure- and the expected timeout-decorated tests are always eligible for rerun regardless of the --rerun-all-issues flag).

If you don't end up needing these expected timeout tests, we can get rid of this whole method.

[labath]

packages/Python/lldbsuite/test/dosep.py

1145

I think this should be target = platform_name, so that you can still match the ios-simulator platform below (the point of the regex was to remove the "remote-" prefix, I believe), but I guess it doesn't really matter, as we are getting rid of the whole function anyway...

[tfiala]

packages/Python/lldbsuite/test/dosep.py

1145

Yep, I agree on both counts:

1. I'll change,
2. It won't matter if/when Ed has a look at this since I don't think we'll need to call out expected timeouts this way.

I'll adjust and submit the adjustment after I test it.

Thanks!

[tfiala]

Closed by svn commit r258542.

packages/Python/lldbsuite/test/dosep.py

 def getExpectedTimeouts(platform_name):
     # returns a set of test filenames that might timeout
     # are we running against a remote target?
-    host = sys.platform
     if platform_name is None:
         target = sys.platform
     else:
         m = re.search(r'remote-(\w+)', platform_name)
-        target = m.group(1)
+        if m:
+            target = m.group(1)
+        else:
+            target = None
 
     expected_timeout = set()
 
-    if target.startswith("freebsd"):
+    if target is not None and target.startswith("freebsd"):
         expected_timeout |= {
             "TestBreakpointConditions.py",
             "TestChangeProcessGroup.py",
             "TestValueObjectRecursion.py",
             "TestWatchpointConditionAPI.py",
         }
-    elif target.startswith("darwin"):
-        expected_timeout |= {
-            # times out on MBP Retina, Mid 2012
-            "TestThreadSpecificBreakpoint.py",
-            "TestExitDuringStep.py",
-            "TestIntegerTypesExpr.py",
-        }
     return expected_timeout