[GlobalISel] Move generic opcodes description to their own file.

[qcolombet]

Summary

Hi Eric,

Does this patch match what you had in mind?

Moreover, the generic opcodes still appear in TargetOpcodes.h and I was thinking that we may want to do something similar. We could move them into their own include, but

• we don't have precedence for this kind of split (usually we do the .inc, but those are generated by TableGen).
• we set the values explicitly in the enum.

Ideas for a follow-up patch?

Thanks,
-Quentin

[echristo]

Yep. That's what I was thinking - and yes, the others are ideas for follow-on patches if it makes sense. It probably does, but it's also probably not worth the effort right now. It shouldn't be any harder later than it is now to do it if so :)

-eric

[qcolombet]

Agreed.

Thanks,
-Quentin

llvm/trunk/include/llvm/Target/GenericOpcodes.td

+//===-- GenericOpcodes.td - Opcodes used with GlobalISel ---*- tablegen -*-===//
+//
+//                     The LLVM Compiler Infrastructure
+//
+// This file is distributed under the University of Illinois Open Source
+// License. See LICENSE.TXT for details.
+//
+//===----------------------------------------------------------------------===//
+//
+// This file defines the generic opcodes used with GlobalISel.
+// After instruction selection, these opcodes should not appear.
+//
+//===----------------------------------------------------------------------===//
+
+// Generic addition.
+def G_ADD : Instruction {
+  let OutOperandList = (outs unknown:$dst);
+  let InOperandList = (ins unknown:$src1, unknown:$src2);
+  let AsmString = "";
+  let hasSideEffects = 0;
+  let isCommutable = 1;
+}
+// TODO: Add the other generic opcodes.

llvm/trunk/include/llvm/Target/Target.td

 }
 def FAULTING_LOAD_OP : Instruction {
   let OutOperandList = (outs unknown:$dst);
   let InOperandList = (ins variable_ops);
   let usesCustomInserter = 1;
   let mayLoad = 1;
 }
 
-// Generic opcode used by the IRTranslator.
-// After ISel, this opcode should not appear.
-def G_ADD : Instruction {
-  let OutOperandList = (outs unknown:$dst);
-  let InOperandList = (ins unknown:$src1, unknown:$src2);
-  let AsmString = "";
-  let hasSideEffects = 0;
-  let isCommutable = 1;
-}
-// TODO: Add the other generic opcodes.
+// Generic opcodes used in GlobalISel.
+include "llvm/Target/GenericOpcodes.td"
+
 }
 
 //===----------------------------------------------------------------------===//
 // AsmParser - This class can be implemented by targets that wish to implement
 // .s file parsing.
 //
 // Subtargets can have multiple different assembly parsers (e.g. AT&T vs Intel
 // syntax on X86 for example).