This is an archive of the discontinued LLVM Phabricator instance.

Differential D16241

[test-suite] Add -pthread to Misc-C++-EH LDFLAGS
ClosedPublic

Authored by mcrosier on Jan 15 2016, 1:23 PM.

Details

Reviewers
kristof.beyls
MatzeB
cmatthews
Summary

The benchmark built under SingleSource/Benchmarks/Misc-C++-EH requires
pthread functions but did not previously have -pthread in LDFLAGS.
This causes an issue when attempting to statically compile the binary.

Diff Detail

Event Timeline

mcrosier updated this revision to Diff 45028.Jan 15 2016, 1:23 PM
mcrosier retitled this revision from to [test-suite] Add -pthread to Misc-C++-EH LDFLAGS.
mcrosier updated this object.
mcrosier added reviewers: MatzeB, cmatthews.
mcrosier added a subscriber: llvm-commits.
mcrosier added a reviewer: kristof.beyls.Jan 15 2016, 1:25 PM
MatzeB accepted this revision.Jan 15 2016, 1:29 PM
MatzeB edited edge metadata.

LGTM, though I would recommend adding list(APPEND CPPFLAGS -pthread) as well then.

This revision is now accepted and ready to land.Jan 15 2016, 1:29 PM
mcrosier closed this revision.Jan 18 2016, 7:47 AM

Committed r258050.

Revision Contents

PathSize
SingleSource/
Benchmarks/
Misc-C++-EH/
2 lines

Diff 45028

SingleSource/Benchmarks/Misc-C++-EH/CMakeLists.txt

list(APPEND LDFLAGS -lm -lstdc++) list(APPEND LDFLAGS -lm -lstdc++ -pthread)
set(LIBS -lstdc++) set(LIBS -lstdc++)
set(REQUIRES_EH_SUPPORT 1) set(REQUIRES_EH_SUPPORT 1)
llvm_singlesource() llvm_singlesource()