Page MenuHomePhabricator

[TestThreadJump] Adjust match sub-string after recent change.
ClosedPublic

Authored by sivachandra on Jan 12 2016, 2:14 PM.

Diff Detail

Event Timeline

sivachandra retitled this revision from to [TestThreadJump] Adjust match sub-string after recent change..
sivachandra updated this object.
sivachandra added a reviewer: zturner.
sivachandra added a subscriber: lldb-commits.
zturner edited edge metadata.Jan 12 2016, 2:17 PM
zturner added a subscriber: zturner.

This isn't going to work either, because Windows doesn't the name=
portion. God I really hate these tests that do substring matching.

I guess there's no easy way to guarantee that the main.cpp:<line-number> is
on the same frame as the breakpoint. Can you change it to:

substrs = ['stopped',

'main.cpp:{}'.format(self.mark3),
'stop reason = breakpoint 1'

]

sivachandra edited edge metadata.

Address comment

zturner accepted this revision.Jan 12 2016, 2:28 PM
zturner edited edge metadata.

If this passes on your side, go ahead. Just from looking, I think it should pass on Windows.

This revision is now accepted and ready to land.Jan 12 2016, 2:28 PM
sivachandra closed this revision.Jan 12 2016, 2:36 PM