This is an archive of the discontinued LLVM Phabricator instance.

Update docs to recommend CMake >= v3.2.
ClosedPublic

Authored by jlebar on Jan 4 2016, 12:00 PM.

Details

Reviewers
echristo
Summary

CMake v3.2 or newer is necessary to get interactive output when running
Lit via Ninja. Otherwise Ninja will buffer Lit's output, which makes
for a crummy experience -- you can't tell if your tests are hung!

Diff Detail

Event Timeline

jlebar updated this revision to Diff 43905.Jan 4 2016, 12:00 PM
jlebar retitled this revision from to Update docs to recommend CMake >= v3.2..
jlebar updated this object.
jlebar added a reviewer: echristo.
jlebar added a subscriber: dblaikie.
echristo edited edge metadata.Jan 4 2016, 12:05 PM
echristo added a subscriber: llvm-commits.

Adding llvm-commits for the review.

echristo accepted this revision.Jan 4 2016, 12:05 PM
echristo edited edge metadata.

LGTM.

Thanks!

-eric

This revision is now accepted and ready to land.Jan 4 2016, 12:05 PM
echristo closed this revision.Jan 4 2016, 3:29 PM

Committed thusly:

dzur:~/sources/llvm> git svn dcommit
Committing to https://llvm.org/svn/llvm-project/llvm/trunk ...
M docs/CMake.rst
M docs/GettingStarted.rst
Committed r256791