This is an archive of the discontinued LLVM Phabricator instance.

[AArch64] Enable PostRAScheduler for AArch64 generic build (take 2)
ClosedPublic

Authored by mcrosier on Dec 18 2015, 1:26 PM.

Details

Summary

This patch enables PostRAScheduler specifically for AArch64 generic build, which is beneficial from the performance perspective.
Speedups up to 2 to 7% for some benchmarks on A57 and A53 are observed. Also benchmarks from LLVM test-suite did not regress.

Original patch here: http://reviews.llvm.org/D15557

This was committed in r255896 and later reverted due to numerous lit test failures.

In this patch I've disabled the post-ra scheduler for all tests that were broken. Before committing my plan is to step through each test to determine if the ordering of instructions matters. If not, then I'm thinking we should leave the post-ra scheduler disabled in order to preserve the history of the test case. If the order of instructions matters then I'll updated the test accordingly. I suspect in most instances we'll just disable the post-ra scheduler.

Chad

Diff Detail

Event Timeline

mcrosier updated this revision to Diff 43260.Dec 18 2015, 1:26 PM
mcrosier retitled this revision from to [AArch64] Enable PostRAScheduler for AArch64 generic build (take 2).
mcrosier updated this object.
mcrosier set the repository for this revision to rL LLVM.
mcrosier added subscribers: llvm-commits, rengolin.
MinSeongKIM accepted this revision.Dec 19 2015, 1:29 AM
MinSeongKIM edited edge metadata.

Hi Chad, LGTM.
This makes sense to me as the tests broken assume no post RA scheduler.
Also I did some work to mute the errors from the broken tests (Please see http://reviews.llvm.org/D15666 the revision is not for upstreaming, but to help the reviewers of "this revision"). I am not sure the changes are all legal and safe, but instruction orders for most of them do not seem matter. I hope it helps.

This revision is now accepted and ready to land.Dec 19 2015, 1:29 AM
mcrosier closed this revision.Dec 21 2015, 6:47 AM

Committed in r256158.