This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU/SI: Fix implemenation of isSourceOfDivergence() for graphics shaders
ClosedPublic

Authored by tstellarAMD on Dec 17 2015, 7:02 AM.

Details

Summary

The analysis of shader inputs was completely wrong. We were passing the
wrong index to AttributeSet::hasAttribute() and the logic for which
inputs where in SGPRs was wrong too.

Diff Detail

Event Timeline

tstellarAMD retitled this revision from to AMDGPU/SI: Fix implemenation of isSourceOfDivergence() for graphics shaders.
tstellarAMD updated this object.
tstellarAMD added a reviewer: arsenm.
tstellarAMD added a subscriber: llvm-commits.
arsenm accepted this revision.Dec 17 2015, 7:22 AM
arsenm edited edge metadata.

LGTM

lib/Target/AMDGPU/AMDGPUTargetTransformInfo.cpp
133

Typo marekd

test/Analysis/DivergenceAnalysis/AMDGPU/kernel-args.ll
3

This can be the -mtriple option to opt

test/Analysis/DivergenceAnalysis/AMDGPU/lit.local.cfg
1

This should be AMDGPU

This revision is now accepted and ready to land.Dec 17 2015, 7:22 AM
This revision was automatically updated to reflect the committed changes.