This is an archive of the discontinued LLVM Phabricator instance.

[libcxx] Enable noexcept for GCC 4.6 and greater
ClosedPublic

Authored by EricWF on Dec 14 2015, 6:42 PM.

Details

Summary

This patch allows GCC 4.6 and above to use noexcept as opposed to throw().

Is it an ABI safe change to suddenly switch on noexcept? I imagine it must be because it's disabled in w/ clang in C++03 but not C++11.

Diff Detail

Event Timeline

EricWF updated this revision to Diff 42812.Dec 14 2015, 6:42 PM
EricWF updated this revision to Diff 42813.
EricWF retitled this revision from to [libcxx] Enable noexcept for GCC 4.6 and greater.
EricWF updated this object.
EricWF added reviewers: mclow.lists, danalbert, jroelofs.
EricWF added a subscriber: cfe-commits.

Woops. I forgot to turn off noexcept support in C++03 mode for GCC.

mclow.lists edited edge metadata.Dec 15 2015, 1:59 PM

do we even use _NOEXCEPT_OR_FALSE any more?

do we even use _NOEXCEPT_OR_FALSE any more?

Doesn't look like it.

mclow.lists accepted this revision.Dec 15 2015, 2:10 PM
mclow.lists edited edge metadata.

Other than the _NOEXCEPT_OR_FALSE thing, this LGTM.

This revision is now accepted and ready to land.Dec 15 2015, 2:10 PM
EricWF closed this revision.Dec 15 2015, 2:19 PM