This is an archive of the discontinued LLVM Phabricator instance.

Make few adjustments after r255542.
ClosedPublic

Authored by sivachandra on Dec 14 2015, 4:17 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

sivachandra retitled this revision from to Make few adjustments after r255542..
sivachandra updated this object.
sivachandra added a reviewer: zturner.
sivachandra added a subscriber: lldb-commits.
This revision was automatically updated to reflect the committed changes.

I went ahead and committed this.

tfiala edited edge metadata.

Yep this fixed the issues I was having on OS X with the related change. Thanks, Siva!

zturner added inline comments.Dec 14 2015, 6:42 PM
lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py
622

I mentioned this in the other thread, but I'm not sure we want the string check. if list_or_lambda is a string, then I think it should just check list_or_lambda == value. Otherwise the test only passes when value is a character, which is not now we use any of the decorators.