This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU/SI: Emit constant variables in the .hsatext section when targeting HSA
ClosedPublic

Authored by tstellarAMD on Dec 10 2015, 11:01 AM.

Diff Detail

Event Timeline

tstellarAMD retitled this revision from to AMDGPU/SI: Emit constant variables in the .hsatext section when targeting HSA.
tstellarAMD updated this object.
tstellarAMD added a reviewer: arsenm.
tstellarAMD added a subscriber: llvm-commits.
arsenm added inline comments.Dec 10 2015, 11:39 AM
lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp
128–135

I would split the HSA vs. Non HSA into separate ifs

Address review comment.

tstellarAMD marked an inline comment as done.Dec 11 2015, 7:42 PM
arsenm accepted this revision.Dec 14 2015, 9:52 AM
arsenm edited edge metadata.

LGTM

This revision is now accepted and ready to land.Dec 14 2015, 9:52 AM
This revision was automatically updated to reflect the committed changes.