This is an archive of the discontinued LLVM Phabricator instance.

[builtins] Avoid using CRT_LDBL_128BIT in implementation. NFC
ClosedPublic

Authored by arichardson on Jun 26 2023, 1:40 PM.

Details

Summary

Currently the *tf builtin functions can only be built if long double is an
IEEE float, which prevents them from being available e.g. for x86 targets
(unlike libgcc which has them). This non-functional change prepares the
builtins library *tf functions for being able to target x86 by decoupling
their presence from CRT_LDBL_128BIT and instead checking for a
CRT_HAS_TF_MODE macro. This change is NFC since the CRT_HAS_TF_MODE is
currently only set if long double is an IEEE 128-bit float.

Diff Detail

Event Timeline

arichardson created this revision.Jun 26 2023, 1:40 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 26 2023, 1:40 PM
Herald added subscribers: Enna1, pengfei. · View Herald Transcript
arichardson requested review of this revision.Jun 26 2023, 1:40 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 26 2023, 1:40 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
compnerd accepted this revision.Jun 30 2023, 8:12 PM
This revision is now accepted and ready to land.Jun 30 2023, 8:12 PM
This revision was landed with ongoing or failed builds.Jul 24 2023, 5:20 PM
This revision was automatically updated to reflect the committed changes.