This is an archive of the discontinued LLVM Phabricator instance.

Differential D15374

Add NetBSD support in the buildDriver and buildLibrary routines
ClosedPublic

Authored by krytarowski on Dec 9 2015, 3:47 AM.

Details

Reviewers
emaste
clay.chang
joerg
tfiala
Commits
rGf5d34b7b9d8b: Add NetBSD support in the buildDriver and buildLibrary routines
rLLDB255308: Add NetBSD support in the buildDriver and buildLibrary routines
rL255308: Add NetBSD support in the buildDriver and buildLibrary routines
Summary

NetBSD is like FreeBSD and Linux in these routines.

Diff Detail

Repository
rL LLVM

Event Timeline

krytarowski updated this revision to Diff 42285.Dec 9 2015, 3:47 AM
krytarowski retitled this revision from to Add NetBSD support in the buildDriver and buildLibrary routines.
krytarowski updated this object.
krytarowski added reviewers: emaste, joerg, clay.chang, tfiala.
krytarowski set the repository for this revision to rL LLVM.
krytarowski added a subscriber: lldb-commits.
Herald added a subscriber: emaste. · View Herald TranscriptDec 9 2015, 3:47 AM
emaste accepted this revision.Dec 9 2015, 6:01 AM
emaste edited edge metadata.
This revision is now accepted and ready to land.Dec 9 2015, 6:01 AM
joerg added inline comments.Dec 9 2015, 6:25 AM
packages/Python/lldbsuite/test/lldbtest.py
2100 ↗(On Diff #42285)

No zero?

emaste requested changes to this revision.Dec 9 2015, 6:45 AM
emaste edited edge metadata.
emaste added inline comments.
packages/Python/lldbsuite/test/lldbtest.py
2100 ↗(On Diff #42285)

Oh, indeed. Zero is necessary.

This revision now requires changes to proceed.Dec 9 2015, 6:45 AM
krytarowski updated this revision to Diff 42372.Dec 9 2015, 7:02 PM
krytarowski edited edge metadata.

Strip zero character from platform name

emaste accepted this revision.Dec 10 2015, 5:13 AM
emaste edited edge metadata.
This revision is now accepted and ready to land.Dec 10 2015, 5:13 AM
joerg accepted this revision.Dec 10 2015, 2:50 PM
joerg edited edge metadata.
krytarowski closed this revision.Dec 10 2015, 2:59 PM
Closed by commit rL255308: Add NetBSD support in the buildDriver and buildLibrary routines (authored by kamil). · Explain WhyDec 10 2015, 2:59 PM
This revision was automatically updated to reflect the committed changes.
krytarowski added a comment.Dec 10 2015, 3:00 PM

Thanks!

Revision Contents

PathSize
lldb/
trunk/
packages/
Python/
lldbsuite/
test/
4 lines

Diff 42467

lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py

Show First 20 Lines • Show All 2,067 Lines • ▼ Show 20 Lines def buildDriver(self, sources, exe_name):
if sys.platform.startswith("darwin"): if sys.platform.startswith("darwin"):
dsym = os.path.join(lib_dir, 'LLDB.framework', 'LLDB') dsym = os.path.join(lib_dir, 'LLDB.framework', 'LLDB')
d = {'CXX_SOURCES' : sources, d = {'CXX_SOURCES' : sources,
'EXE' : exe_name, 'EXE' : exe_name,
'CFLAGS_EXTRAS' : "%s %s" % (stdflag, stdlibflag), 'CFLAGS_EXTRAS' : "%s %s" % (stdflag, stdlibflag),
'FRAMEWORK_INCLUDES' : "-F%s" % lib_dir, 'FRAMEWORK_INCLUDES' : "-F%s" % lib_dir,
'LD_EXTRAS' : "%s -Wl,-rpath,%s" % (dsym, lib_dir), 'LD_EXTRAS' : "%s -Wl,-rpath,%s" % (dsym, lib_dir),
} }
elif sys.platform.startswith('freebsd') or sys.platform.startswith("linux") or os.environ.get('LLDB_BUILD_TYPE') == 'Makefile': elif sys.platform.rstrip('0123456789') in ('freebsd', 'linux', 'netbsd') or os.environ.get('LLDB_BUILD_TYPE') == 'Makefile':
d = {'CXX_SOURCES' : sources, d = {'CXX_SOURCES' : sources,
'EXE' : exe_name, 'EXE' : exe_name,
'CFLAGS_EXTRAS' : "%s %s -I%s" % (stdflag, stdlibflag, os.path.join(os.environ["LLDB_SRC"], "include")), 'CFLAGS_EXTRAS' : "%s %s -I%s" % (stdflag, stdlibflag, os.path.join(os.environ["LLDB_SRC"], "include")),
'LD_EXTRAS' : "-L%s -llldb" % lib_dir} 'LD_EXTRAS' : "-L%s -llldb" % lib_dir}
elif sys.platform.startswith('win'): elif sys.platform.startswith('win'):
d = {'CXX_SOURCES' : sources, d = {'CXX_SOURCES' : sources,
'EXE' : exe_name, 'EXE' : exe_name,
'CFLAGS_EXTRAS' : "%s %s -I%s" % (stdflag, stdlibflag, os.path.join(os.environ["LLDB_SRC"], "include")), 'CFLAGS_EXTRAS' : "%s %s -I%s" % (stdflag, stdlibflag, os.path.join(os.environ["LLDB_SRC"], "include")),
Show All 12 Lines def buildLibrary(self, sources, lib_name):
if self.platformIsDarwin(): if self.platformIsDarwin():
dsym = os.path.join(lib_dir, 'LLDB.framework', 'LLDB') dsym = os.path.join(lib_dir, 'LLDB.framework', 'LLDB')
d = {'DYLIB_CXX_SOURCES' : sources, d = {'DYLIB_CXX_SOURCES' : sources,
'DYLIB_NAME' : lib_name, 'DYLIB_NAME' : lib_name,
'CFLAGS_EXTRAS' : "%s -stdlib=libc++" % stdflag, 'CFLAGS_EXTRAS' : "%s -stdlib=libc++" % stdflag,
'FRAMEWORK_INCLUDES' : "-F%s" % lib_dir, 'FRAMEWORK_INCLUDES' : "-F%s" % lib_dir,
'LD_EXTRAS' : "%s -Wl,-rpath,%s -dynamiclib" % (dsym, lib_dir), 'LD_EXTRAS' : "%s -Wl,-rpath,%s -dynamiclib" % (dsym, lib_dir),
} }
elif self.getPlatform() == 'freebsd' or self.getPlatform() == 'linux' or os.environ.get('LLDB_BUILD_TYPE') == 'Makefile': elif self.getPlatform() in ('freebsd', 'linux', 'netbsd') or os.environ.get('LLDB_BUILD_TYPE') == 'Makefile':
d = {'DYLIB_CXX_SOURCES' : sources, d = {'DYLIB_CXX_SOURCES' : sources,
'DYLIB_NAME' : lib_name, 'DYLIB_NAME' : lib_name,
'CFLAGS_EXTRAS' : "%s -I%s -fPIC" % (stdflag, os.path.join(os.environ["LLDB_SRC"], "include")), 'CFLAGS_EXTRAS' : "%s -I%s -fPIC" % (stdflag, os.path.join(os.environ["LLDB_SRC"], "include")),
'LD_EXTRAS' : "-shared -L%s -llldb" % lib_dir} 'LD_EXTRAS' : "-shared -L%s -llldb" % lib_dir}
elif self.getPlatform() == 'windows': elif self.getPlatform() == 'windows':
d = {'DYLIB_CXX_SOURCES' : sources, d = {'DYLIB_CXX_SOURCES' : sources,
'DYLIB_NAME' : lib_name, 'DYLIB_NAME' : lib_name,
'CFLAGS_EXTRAS' : "%s -I%s -fPIC" % (stdflag, os.path.join(os.environ["LLDB_SRC"], "include")), 'CFLAGS_EXTRAS' : "%s -I%s -fPIC" % (stdflag, os.path.join(os.environ["LLDB_SRC"], "include")),
▲ Show 20 Lines • Show All 697 Lines • Show Last 20 Lines