This is an archive of the discontinued LLVM Phabricator instance.

[test] Add test for null_pointer_is_valid and Inliner instsimplify interaction
ClosedPublic

Authored by aeubanks on Jun 21 2023, 8:32 AM.

Diff Detail

Event Timeline

aeubanks created this revision.Jun 21 2023, 8:32 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 21 2023, 8:32 AM
aeubanks requested review of this revision.Jun 21 2023, 8:32 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 21 2023, 8:32 AM
arsenm added inline comments.Jun 21 2023, 8:34 AM
llvm/test/Transforms/Inline/instsimplify-null-pointer-is-valid.ll
4

Add comment explaining the test

aeubanks updated this revision to Diff 533280.Jun 21 2023, 8:37 AM

add comment

arsenm accepted this revision.Jun 21 2023, 8:39 AM
arsenm added inline comments.
llvm/test/Transforms/Inline/instsimplify-null-pointer-is-valid.ll
24

Could also test what happens if the either the caller or callee is missing the attribute

This revision is now accepted and ready to land.Jun 21 2023, 8:39 AM
aeubanks updated this revision to Diff 533387.Jun 21 2023, 2:00 PM

add test where caller has null_pointer_is_valid but not callee
(vice versa is already tested to make sure it's not inlined)

This revision was landed with ongoing or failed builds.Jun 21 2023, 2:01 PM
This revision was automatically updated to reflect the committed changes.