This is an archive of the discontinued LLVM Phabricator instance.

docs: Correct wording in LangRef relating to available_externally linkage.
ClosedPublic

Authored by pcc on Dec 8 2015, 11:30 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

pcc updated this revision to Diff 42203.Dec 8 2015, 11:30 AM
pcc retitled this revision from to docs: Correct wording in LangRef relating to available_externally linkage..
pcc updated this object.
pcc added reviewers: rafael, mehdi_amini.
pcc added a subscriber: llvm-commits.
mehdi_amini edited edge metadata.Dec 8 2015, 11:40 AM

Looks good to me, let's wait for Rafael.

rafael added inline comments.Dec 8 2015, 1:35 PM
docs/LangRef.rst
215 ↗(On Diff #42203)

Maybe drop the reference to linkonce_odr completely?

pcc updated this revision to Diff 42251.Dec 8 2015, 4:55 PM
pcc edited edge metadata.
  • Remove reference to linkonce_odr linkage
rafael accepted this revision.Dec 8 2015, 5:03 PM
rafael edited edge metadata.

LGTM

This revision is now accepted and ready to land.Dec 8 2015, 5:03 PM
This revision was automatically updated to reflect the committed changes.
pcc marked an inline comment as done.