This is an archive of the discontinued LLVM Phabricator instance.

parseArch() supports more variations of arch names
ClosedPublic

Authored by kkwli0 on Dec 4 2015, 11:08 AM.

Details

Summary

It is a regression from r249391. The following test failures are found if the build is configured as 'cmake -DLLVM_TARGETS_TO_BUILD="PowerPC" ...'.

Clang-Unit :: Tooling/Release/ToolingTests/addTargetAndModeForProgramName.AddsTargetAndMode
Clang-Unit :: Tooling/Release/ToolingTests/addTargetAndModeForProgramName.IgnoresExistingMode
Clang-Unit :: Tooling/Release/ToolingTests/addTargetAndModeForProgramName.IgnoresExistingTarget
Clang-Unit :: Tooling/Release/ToolingTests/addTargetAndModeForProgramName.PathIgnored

The problem is due to a mismatch between the entries in the target registry and what arch name parseArch() can recognize. For example, with -DLLVM_TARGETS_TO_BUILD="PowerPC", the target registry will have ppc32, ppc64 and ppc64le. When one of those is used in parseArch() to construct part of the triple, an unknown is returned. Similar problem occurs with builds only targeting systemz.

Diff Detail

Event Timeline

kkwli0 updated this revision to Diff 41900.Dec 4 2015, 11:08 AM
kkwli0 retitled this revision from to parseArch() supports more variations of arch names.
kkwli0 updated this object.
kkwli0 added subscribers: llvm-commits, fraggamuffin.
kbarton accepted this revision.Jan 7 2016, 3:28 PM
kbarton edited edge metadata.
This revision is now accepted and ready to land.Jan 7 2016, 3:28 PM
kkwli0 closed this revision.Jan 18 2016, 6:10 PM

Committed revision 258103.