This is an archive of the discontinued LLVM Phabricator instance.

Add support for fcomip, fucomip for Intel syntax
ClosedPublic

Authored by myatsina on Dec 1 2015, 1:56 AM.

Details

Summary

According to x86 spec, fcomip and fucomip should be supported for Intel syntax.

Diff Detail

Repository
rL LLVM

Event Timeline

myatsina updated this revision to Diff 41473.Dec 1 2015, 1:56 AM
myatsina retitled this revision from to Add support for fcomip, fucomip for Intel syntax.
myatsina updated this object.
myatsina added reviewers: rnk, mcrosier.
myatsina set the repository for this revision to rL LLVM.
myatsina added a subscriber: llvm-commits.
mcrosier added inline comments.Dec 1 2015, 6:08 AM
test/MC/X86/intel-syntax.s
740

Why is the mnemonic used in the inline asm different than the mnemonic emitted by llvm-mc (i.e., *ip vs *pi)?

myatsina added inline comments.Dec 1 2015, 8:05 AM
test/MC/X86/intel-syntax.s
740

Notice this test's output is in att syntax.
Also, the canonical form of the instruction was changed a while ago from "ip" to "pi" because of some bug in gas:
http://llvm.org/viewvc/llvm-project?view=revision&revision=118356

mcrosier edited edge metadata.Dec 1 2015, 8:53 AM

Got it, thanks. LGTM.

mcrosier accepted this revision.Dec 1 2015, 8:53 AM
mcrosier edited edge metadata.
This revision is now accepted and ready to land.Dec 1 2015, 8:53 AM
rnk accepted this revision.Dec 1 2015, 9:02 AM
rnk edited edge metadata.

Yup, lgtm

This revision was automatically updated to reflect the committed changes.