This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU/SI: Prevent the DAGCombiner from creating setcc with i1 inputs
ClosedPublic

Authored by tstellarAMD on Nov 27 2015, 3:10 AM.

Diff Detail

Event Timeline

tstellarAMD retitled this revision from to AMDGPU/SI: Prevent the DAGCombiner from creating setcc with i1 inputs.
tstellarAMD updated this object.
tstellarAMD added a reviewer: arsenm.
tstellarAMD added a subscriber: llvm-commits.
arsenm added inline comments.Jan 15 2016, 10:55 AM
lib/Target/AMDGPU/SIISelLowering.cpp
512–516

I think this should only do this for Op == ISD:SETCC.

We probably do want i1 logical operations to use the scalar 64-bit instructions on the results.

Keep i1 as desirable for non-sett ops.

Fix missing ampersand.

arsenm accepted this revision.Jan 18 2016, 1:20 PM
arsenm edited edge metadata.

LGTM

This revision is now accepted and ready to land.Jan 18 2016, 1:20 PM
This revision was automatically updated to reflect the committed changes.