This is an archive of the discontinued LLVM Phabricator instance.

[ELF] - split RelocationSection<ELFT>::writeTo function.
ClosedPublic

Authored by grimar on Nov 26 2015, 5:02 AM.

Diff Detail

Event Timeline

grimar updated this revision to Diff 41233.Nov 26 2015, 5:02 AM
grimar retitled this revision from to [ELF] - split RelocationSection<ELFT>::writeTo function..
grimar updated this object.
grimar added reviewers: ruiu, rafael.
grimar added subscribers: llvm-commits, grimar.
ruiu added inline comments.Nov 26 2015, 9:35 AM
ELF/OutputSections.cpp
196

Can you add a function comment?

202–204

If a function is named isXXX, it is usually expected to be a 'pure' function that does not change anything. It updates the arguments, so you may want to change the name.

grimar updated this revision to Diff 41357.Nov 29 2015, 3:34 PM
grimar updated this object.
grimar added inline comments.
ELF/OutputSections.cpp
196

Done.

202–204

Ok. Thanks for hint. Renamed to applyTlsDynamicReloc().

ruiu accepted this revision.Nov 30 2015, 9:16 AM
ruiu edited edge metadata.

LGTM

ELF/OutputSections.cpp
197

Remove "false otherwise" as it's obvious.

This revision is now accepted and ready to land.Nov 30 2015, 9:16 AM
This revision was automatically updated to reflect the committed changes.
grimar added inline comments.Nov 30 2015, 9:52 AM
ELF/OutputSections.cpp
197

Done.