This is an archive of the discontinued LLVM Phabricator instance.

Make tbm-builtins.c as X86 specific unit test
ClosedPublic

Authored by sgundapa on Nov 20 2015, 1:45 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

sgundapa updated this revision to Diff 40824.Nov 20 2015, 1:45 PM
sgundapa retitled this revision from to Make tbm-builtins.c as X86 specific unit test.
sgundapa updated this object.
sgundapa added reviewers: echristo, craig.topper.
sgundapa added a subscriber: cfe-commits.
echristo accepted this revision.Nov 20 2015, 3:17 PM
echristo edited edge metadata.

This is fine. One inline comment.

-eric

test/CodeGen/tbm-builtins.c
2–3 ↗(On Diff #40824)

Go ahead and put the REQUIRES underneath the FIXME and add a note to the effect that the REQUIRES can be removed when the FIXME is complete.

This revision is now accepted and ready to land.Nov 20 2015, 3:17 PM
This revision was automatically updated to reflect the committed changes.

Merged this as r253887