[libcxx] Replace TEST_HAS_NO_EXCEPTIONS with _LIBCPP_NO_EXCEPTIONS [NFC]

[rmaprath]

Summary

The macro TEST_HAS_NO_EXCEPTIONS seems to be defined very similar to _LIBCPP_NO_EXCEPTIONS, I'm thinking of getting rid of the former as the latter is more general (defined in __config).

I'm curious as to why the TEST_HAS_NO_EXCEPTIONS macro was introduced? Until very recently, we did not have any -fno-exceptions test runs AFAIK.

If readability is the reason for this macro, we can instead do:

#define TEST_HAS_NO_EXCEPTIONS _LIBCPP_NO_EXCEPTIONS

No functional changes.

[jroelofs]

This change is not the right thing to do. The reason this is a separate macro is that we don't want the tests in test/std to depend on implementation details of libcxx itself.

[EricWF]

@jroelofs +1. We are trying to make our test suite generic enough that other STL maintainers may use it and contribute to it.

[rmaprath]

Makes sense. Thanks.

test/std/experimental/any/any.class/any.assign/copy.pass.cpp

 template <class Tp>
 void test_copy_assign_throws()
 {
-#if !defined(TEST_HAS_NO_EXCEPTIONS)
+#ifndef _LIBCPP_NO_EXCEPTIONS
     auto try_throw =
     [](any& lhs, any const& rhs) {
         try {

test/std/experimental/any/any.class/any.assign/value.pass.cpp

 
 template <class Tp, bool Move = false>
 void test_assign_throws() {
-#if !defined(TEST_HAS_NO_EXCEPTIONS)
+#ifndef _LIBCPP_NO_EXCEPTIONS
     auto try_throw=
     [](any& lhs, auto&& rhs) {
         try {

test/std/experimental/any/any.class/any.cons/copy.pass.cpp

 
 template <class Type>
 void test_copy_throws() {
-#if !defined(TEST_HAS_NO_EXCEPTIONS)
+#ifndef _LIBCPP_NO_EXCEPTIONS
     assert(Type::count == 0);
     {
         any const a((Type(42)));

test/std/experimental/any/any.class/any.cons/move.pass.cpp

 // not the stored object.
 void test_move_does_not_throw()
 {
-#if !defined(TEST_HAS_NO_EXCEPTIONS)
+#ifndef _LIBCPP_NO_EXCEPTIONS
     assert(throws_on_move::count == 0);
     {
         throws_on_move v(42);

test/std/experimental/any/any.class/any.cons/value.pass.cpp

 template <class Type>
 void test_copy_value_throws()
 {
-#if !defined(TEST_HAS_NO_EXCEPTIONS)
+#ifndef _LIBCPP_NO_EXCEPTIONS
     assert(Type::count == 0);
     {
         Type const t(42);

 
 void test_move_value_throws()
 {
-#if !defined(TEST_HAS_NO_EXCEPTIONS)
+#ifndef _LIBCPP_NO_EXCEPTIONS
     assert(throws_on_move::count == 0);
     {
         throws_on_move v;

test/std/experimental/any/any.nonmembers/any.cast/any_cast_reference.pass.cpp

 template <class Type, class ConstT = Type>
 void checkThrows(any& a)
 {
-#if !defined(TEST_HAS_NO_EXCEPTIONS)
+#ifndef _LIBCPP_NO_EXCEPTIONS
     try {
         any_cast<Type>(a);
         assert(false);

test/support/any_helpers.h

 struct my_any_exception {};
 
 void throwMyAnyExpression() {
-#if !defined(TEST_HAS_NO_EXCEPTIONS)
+#ifndef _LIBCPP_NO_EXCEPTIONS
         throw my_any_exception();
 #else
         assert(false && "Exceptions are disabled");

test/support/test_macros.h

 #define TEST_HAS_NO_RTTI
 #endif
 
-#if !TEST_HAS_FEATURE(cxx_exceptions) && !defined(__cxx_exceptions)
-#define TEST_HAS_NO_EXCEPTIONS
-#endif
-
 #if TEST_HAS_FEATURE(address_sanitizer) || TEST_HAS_FEATURE(memory_sanitizer) || \
     TEST_HAS_FEATURE(thread_sanitizer)
 #define TEST_HAS_SANITIZERS