This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU/SI: Correctly emit program global variables when targeting HSA
ClosedPublic

Authored by tstellarAMD on Nov 9 2015, 12:25 PM.

Diff Detail

Event Timeline

tstellarAMD retitled this revision from to AMDGPU/SI: Correctly emit program global variables when targeting HSA.
tstellarAMD updated this object.
tstellarAMD added a reviewer: arsenm.
tstellarAMD added a subscriber: llvm-commits.
arsenm accepted this revision.Nov 9 2015, 12:30 PM
arsenm edited edge metadata.

LGTM

This revision is now accepted and ready to land.Nov 9 2015, 12:30 PM
tstellarAMD edited edge metadata.

Fixing handling of linkage and allocation types

arsenm added inline comments.Dec 1 2015, 9:08 AM
lib/Target/AMDGPU/AMDGPUHSATargetObjectFile.cpp
58–62

The isAgentAllocation vs. isProgramAllocation can be moved under a single isGlobalSegment

Address review comment.

tstellarAMD requested a review of this revision.Dec 1 2015, 9:24 AM
tstellarAMD edited edge metadata.
tstellarAMD marked an inline comment as done.
arsenm accepted this revision.Dec 1 2015, 9:25 AM
arsenm edited edge metadata.

LGTM

This revision is now accepted and ready to land.Dec 1 2015, 9:25 AM
This revision was automatically updated to reflect the committed changes.