Page MenuHomePhabricator

Treat hostname in android URL as device id unless it matches "localhost"
ClosedPublic

Authored by ovyalov on Oct 26 2015, 7:04 PM.

Details

Summary

We can connect to a device using various protocols (tcp, unix domain, abstract).
Instead of adding new URL schemes (e.g., adb-unix, adb-abstract) to cover alternative transport we can use standard connect URLs together with device id as hostname, unless it matches "localhost".
If hostname is "localhost" then we expect a single connected device.

Diff Detail

Event Timeline

ovyalov updated this revision to Diff 38490.Oct 26 2015, 7:04 PM
ovyalov retitled this revision from to Treat hostname in android URL as device id unless it matches "localhost".
ovyalov updated this object.
ovyalov added reviewers: tberghammer, labath.
ovyalov added a subscriber: lldb-commits.
labath accepted this revision.Oct 27 2015, 2:17 AM
labath edited edge metadata.

I like this. (I assume it will work with the tcp-connected devices which have an ID like ???:port)

This revision is now accepted and ready to land.Oct 27 2015, 2:17 AM
tberghammer accepted this revision.Oct 27 2015, 3:37 AM
tberghammer edited edge metadata.

I like this. (I assume it will work with the tcp-connected devices which have an ID like ???:port)

Yes - definitely.