Use Twin instead of std::to_string

[ovyalov]

Summary

Use Twin instead of std::to_string - in order to make lib/Bitcode/Reader/BitcodeReader.cpp compatible with Android build.

[jroelofs]

LGTM with that change.

lib/Bitcode/Reader/BitcodeReader.cpp

3115–3116

Drop the temporaries while you're at it:

return error(Twine("Incompatible epoch: Bitcode '") + epoch +
             "' vs current: '" + bitc::BITCODE_CURRENT_EPOCH + "'");

[ovyalov]

Addressed review comment.

[mehdi_amini]

lib/Bitcode/Reader/BitcodeReader.cpp

3115–3116

+1, I wish I knew Twine accepts this :)

[jroelofs]

Ah, right, I forgot those constructors were marked explicit.... LGTM!

[ovyalov]

Submitted as http://reviews.llvm.org/rL251365

lib/Bitcode/Reader/BitcodeReader.cpp

default: // Default behavior: reject
       return error("Invalid value");
     case bitc::IDENTIFICATION_CODE_STRING: { // IDENTIFICATION:      [strchr x
                                              // N]
       convertToString(Record, 0, ProducerIdentification);
       break;
     }
     case bitc::IDENTIFICATION_CODE_EPOCH: { // EPOCH:      [epoch#]
       unsigned epoch = (unsigned)Record[0];
       if (epoch != bitc::BITCODE_CURRENT_EPOCH) {
-        auto BitcodeEpoch = std::to_string(epoch);
-        auto CurrentEpoch = std::to_string(bitc::BITCODE_CURRENT_EPOCH);
-        return error(Twine("Incompatible epoch: Bitcode '") + BitcodeEpoch +
-                     "' vs current: '" + CurrentEpoch + "'");
+        return error(
+          Twine("Incompatible epoch: Bitcode '") + Twine(epoch) +
+          "' vs current: '" + Twine(bitc::BITCODE_CURRENT_EPOCH) + "'");
       }
     }
     }
   }
 }
 
 std::error_code BitcodeReader::parseModule(uint64_t ResumeBit,
                                            bool ShouldLazyLoadMetadata) {