This change deprecates -m/+m dotest options (the options are still recognized but they print an
error message pointing to the new options) and adds a new lldb-mi test category instead. To just
run lldb-mi tests, use '-G lldb-mi'. To skip lldb-mi tests, use '--skip-category lldb-mi'. All
lldb-mi tests are marked as such using the getCategories method on the base MiTestCaseBase class
and the @lldbmi_test decorator is not needed. In case one still needs to annotate a specific test
function as an lldb-mi test, one can use the @add_test_categories(['lldb-mi']) decorator to
achieve that.
Details
Diff Detail
- Repository
- rL LLVM
Event Timeline
Before commit please sync with Ying about updating all android build bot to still skip the MI tests after the change.
I've got it covered. :)
I will commit this tomorrow, to give more people a chance to see what is coming.
LGTM.
Who currently owns the MI tests (or system) these days? I suppose you are doing this to squelch them from failing on the buildbots. On our end, we see the MI tests fail fairly frequently, typically intermittently.
We have XFAILed MI tests that were failing on our linux build bot. Atm, I am seeing expected passes, so I might try enabling them soon...
However, these tests are not remote-ready, so we have to skip them on the android built bots.
I have been seeing them fail intermittently on both OS X and Ubuntu 14.04/15.10. They seem to pass most of the time, but I'd say something like one in 3 or 4 runs, at least one of the MI tests fail.