This is an archive of the discontinued LLVM Phabricator instance.

InstCombine: fix sinking of convergent calls
ClosedPublic

Authored by escha on Oct 26 2015, 12:17 AM.

Details

Diff Detail

Repository
rL LLVM

Event Timeline

escha updated this revision to Diff 38376.Oct 26 2015, 12:17 AM
escha retitled this revision from to InstCombine: fix sinking of convergent calls.
escha updated this object.
escha added reviewers: resistor, arsenm.
escha set the repository for this revision to rL LLVM.
escha added a subscriber: llvm-commits.

Might be nice to share the logic with Sink.cpp, I guess it would hinge on
an appropriate name for a predicate.

escha added a comment.Nov 3 2015, 11:44 AM

Ping?

I think if we're going to merge the logic here we should probably do the refactoring separately from any correctness changes.

majnemer accepted this revision.Nov 3 2015, 1:02 PM
majnemer added a reviewer: majnemer.

LGTM.

This revision is now accepted and ready to land.Nov 3 2015, 1:02 PM
escha closed this revision.Nov 3 2015, 2:37 PM