This is an archive of the discontinued LLVM Phabricator instance.

Make uses of metaclasses portable across Python versions
ClosedPublic

Authored by zturner on Oct 20 2015, 1:31 PM.

Details

Reviewers
tfiala
Summary

This uses the six.add_metaclass() decorator for portable metaclass specification.

Diff Detail

Event Timeline

zturner updated this revision to Diff 37913.Oct 20 2015, 1:31 PM
zturner retitled this revision from to Make uses of metaclasses portable across Python versions.
zturner updated this object.
zturner added a reviewer: tfiala.
zturner added a subscriber: lldb-commits.
tfiala accepted this revision.Oct 20 2015, 1:45 PM
tfiala edited edge metadata.

Looks good.

This revision is now accepted and ready to land.Oct 20 2015, 1:45 PM

Thanks. This is still blocked on my 2 earlier CLs (one adding six to the repo, and the other hooking up six to be recognized by dotest). If you get a chance can you take a look at those?

Thanks. This is still blocked on my 2 earlier CLs (one adding six to the repo, and the other hooking up six to be recognized by dotest). If you get a chance can you take a look at those?

Yep, I didn't read them in time order :-) All 3 looked good.

Sure thing!

zturner closed this revision.Oct 20 2015, 2:11 PM