This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU/SI: Emit constant arrays in the .hsrodata_readonly_agent section
ClosedPublic

Authored by tstellarAMD on Oct 16 2015, 6:11 AM.

Diff Detail

Event Timeline

tstellarAMD retitled this revision from to AMDGPU/SI: Emit constant arrays in the .hsrodata_readonly_agent section.
tstellarAMD updated this object.
tstellarAMD added a reviewer: arsenm.
tstellarAMD added a subscriber: llvm-commits.
arsenm added inline comments.Nov 3 2015, 1:37 PM
test/CodeGen/AMDGPU/hsa-globals.ll
9

Should there be tests with a variety of alignments?

Rebase after changes to D13806

test/CodeGen/AMDGPU/hsa-globals.ll
9

Maybe, I'm not sure exactly how the output would be different.

arsenm accepted this revision.Nov 30 2015, 1:26 PM
arsenm edited edge metadata.

LGTM

This revision is now accepted and ready to land.Nov 30 2015, 1:26 PM
tstellarAMD edited edge metadata.

Rebased on top of recent changes.

This revision was automatically updated to reflect the committed changes.