Remove long-forgotten plugin virtuals.

[brucem]

Summary

EnablePluginLogging, GetPluginCommandHelp and ExecutePluginCommand aren't
implemented or used anywhere, so remove them from the Hexagon and POSIX
Dynamic Loaders as well as the FreeBSD process.

[labath]

lgtm

lldb/trunk/source/Plugins/DynamicLoader/Hexagon-DYLD/DynamicLoaderHexagonDYLD.h

public:
     // PluginInterface protocol
     //------------------------------------------------------------------
     virtual lldb_private::ConstString
     GetPluginName() override;
 
     virtual uint32_t
     GetPluginVersion() override;
 
-    virtual void
-    GetPluginCommandHelp(const char *command, lldb_private::Stream *strm);
-
-    virtual lldb_private::Error
-    ExecutePluginCommand(lldb_private::Args &command, lldb_private::Stream *strm);
-
-    virtual lldb_private::Log *
-    EnablePluginLogging(lldb_private::Stream *strm, lldb_private::Args &command);
-
 protected:
     /// Runtime linker rendezvous structure.
     HexagonDYLDRendezvous m_rendezvous;
 
     /// Virtual load address of the inferior process.
     lldb::addr_t m_load_offset;
 
     /// Virtual entry address of the inferior process.

lldb/trunk/source/Plugins/DynamicLoader/Hexagon-DYLD/DynamicLoaderHexagonDYLD.cpp

 
 const char *
 DynamicLoaderHexagonDYLD::GetPluginDescriptionStatic()
 {
     return "Dynamic loader plug-in that watches for shared library "
            "loads/unloads in Hexagon processes.";
 }
 
-void
-DynamicLoaderHexagonDYLD::GetPluginCommandHelp(const char *command, Stream *strm)
-{
-}
-
 uint32_t
 DynamicLoaderHexagonDYLD::GetPluginVersion()
 {
     return 1;
 }
 
 DynamicLoader *
 DynamicLoaderHexagonDYLD::CreateInstance(Process *process, bool force)
if (executable.get() != target.GetExecutableModulePointer())
         // and find out about all images that are loaded
         const bool get_dependent_images = false;
         target.SetExecutableModule(executable, get_dependent_images);
     }
     
     return executable;
 }
 
-Error
-DynamicLoaderHexagonDYLD::ExecutePluginCommand(Args &command, Stream *strm)
-{
-    return Error();
-}
-
-Log *
-DynamicLoaderHexagonDYLD::EnablePluginLogging(Stream *strm, Args &command)
-{
-    return NULL;
-}
-
 //AD: Needs to be updated?
 Error
 DynamicLoaderHexagonDYLD::CanLoadImage()
 {
     return Error();
 }
 
 void

lldb/trunk/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.h

public:
     // PluginInterface protocol
     //------------------------------------------------------------------
     virtual lldb_private::ConstString
     GetPluginName() override;
 
     virtual uint32_t
     GetPluginVersion() override;
 
-    virtual void
-    GetPluginCommandHelp(const char *command, lldb_private::Stream *strm);
-
-    virtual lldb_private::Error
-    ExecutePluginCommand(lldb_private::Args &command, lldb_private::Stream *strm);
-
-    virtual lldb_private::Log *
-    EnablePluginLogging(lldb_private::Stream *strm, lldb_private::Args &command);
-
 protected:
     /// Runtime linker rendezvous structure.
     DYLDRendezvous m_rendezvous;
 
     /// Virtual load address of the inferior process.
     lldb::addr_t m_load_offset;
 
     /// Virtual entry address of the inferior process.

lldb/trunk/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp

 
 const char *
 DynamicLoaderPOSIXDYLD::GetPluginDescriptionStatic()
 {
     return "Dynamic loader plug-in that watches for shared library "
            "loads/unloads in POSIX processes.";
 }
 
-void
-DynamicLoaderPOSIXDYLD::GetPluginCommandHelp(const char *command, Stream *strm)
-{
-}
-
 uint32_t
 DynamicLoaderPOSIXDYLD::GetPluginVersion()
 {
     return 1;
 }
 
 DynamicLoader *
 DynamicLoaderPOSIXDYLD::CreateInstance(Process *process, bool force)
if (executable.get() && load_offset != LLDB_INVALID_ADDRESS)
             log->Printf ("DynamicLoaderPOSIXDYLD::%s about to call ProbeEntry()", __FUNCTION__);
         ProbeEntry();
 
         m_process->GetTarget().ModulesDidLoad(module_list);
     }
 }
 
 Error
-DynamicLoaderPOSIXDYLD::ExecutePluginCommand(Args &command, Stream *strm)
-{
-    return Error();
-}
-
-Log *
-DynamicLoaderPOSIXDYLD::EnablePluginLogging(Stream *strm, Args &command)
-{
-    return NULL;
-}
-
-Error
 DynamicLoaderPOSIXDYLD::CanLoadImage()
 {
     return Error();
 }
 
 void
 DynamicLoaderPOSIXDYLD::UpdateLoadedSections(ModuleSP module,
                                              addr_t link_map_addr,

lldb/trunk/source/Plugins/Process/FreeBSD/ProcessFreeBSD.h

public:
     // PluginInterface protocol
     //------------------------------------------------------------------
     virtual lldb_private::ConstString
     GetPluginName();
 
     virtual uint32_t
     GetPluginVersion();
 
-    virtual void
-    GetPluginCommandHelp(const char *command, lldb_private::Stream *strm);
-
-    virtual lldb_private::Error
-    ExecutePluginCommand(lldb_private::Args &command,
-                         lldb_private::Stream *strm);
-
-    virtual lldb_private::Log *
-    EnablePluginLogging(lldb_private::Stream *strm,
-                        lldb_private::Args &command);
-
 public:
     //------------------------------------------------------------------
     // Process protocol.
     //------------------------------------------------------------------
     void
     Finalize() override;
 
     bool

lldb/trunk/source/Plugins/Process/FreeBSD/ProcessFreeBSD.cpp

 
 uint32_t
 ProcessFreeBSD::GetPluginVersion()
 {
     return 1;
 }
 
 void
-ProcessFreeBSD::GetPluginCommandHelp(const char *command, Stream *strm)
-{
-}
-
-Error
-ProcessFreeBSD::ExecutePluginCommand(Args &command, Stream *strm)
-{
-    return Error(1, eErrorTypeGeneric);
-}
-
-Log *
-ProcessFreeBSD::EnablePluginLogging(Stream *strm, Args &command)
-{
-    return NULL;
-}
-
-void
 ProcessFreeBSD::Terminate()
 {
 }
 
 Error
 ProcessFreeBSD::DoDetach(bool keep_stopped)
 {
     Error error;