This is an archive of the discontinued LLVM Phabricator instance.

[ELF2] Make VAStart a Target-dependent property
ClosedPublic

Authored by hfinkel on Oct 8 2015, 9:42 AM.

Details

Summary

This patch addresses the FIXME in ELF/Writer.cpp, and makes VAStart a target-dependent property. I've set the values for the existing targets to what I believe to be the correct values, and updated the regression tests accordingly.

Diff Detail

Repository
rL LLVM

Event Timeline

hfinkel updated this revision to Diff 36865.Oct 8 2015, 9:42 AM
hfinkel retitled this revision from to [ELF2] Make VAStart a Target-dependent property.
hfinkel updated this object.
hfinkel added reviewers: ruiu, rafael, davide.
hfinkel added a project: lld.
hfinkel added a subscriber: llvm-commits.
ruiu accepted this revision.Oct 8 2015, 9:57 AM
ruiu edited edge metadata.

LGTM with a nit.

ELF/Target.h
42

I think this has to be uint64_t. Otherwise it can't handle large addresses when cross-linking 32-bit host/64-bit target.

This revision is now accepted and ready to land.Oct 8 2015, 9:57 AM
davide accepted this revision.Oct 8 2015, 10:39 AM
davide edited edge metadata.

LGTM. Nice.

hfinkel closed this revision.Oct 8 2015, 12:39 PM
hfinkel marked an inline comment as done.

r249723, thanks!

ELF/Target.h
42

Done.