This patch addresses the FIXME in ELF/Writer.cpp, and makes VAStart a target-dependent property. I've set the values for the existing targets to what I believe to be the correct values, and updated the regression tests accordingly.
Diff Detail
Diff Detail
- Repository
- rL LLVM
Event Timeline
Comment Actions
LGTM with a nit.
ELF/Target.h | ||
---|---|---|
42 | I think this has to be uint64_t. Otherwise it can't handle large addresses when cross-linking 32-bit host/64-bit target. |
I think this has to be uint64_t. Otherwise it can't handle large addresses when cross-linking 32-bit host/64-bit target.