This is an archive of the discontinued LLVM Phabricator instance.

[CodeGen] Attach function attributes to functions created in CGBlocks.cpp.
ClosedPublic

Authored by ahatanak on Oct 7 2015, 11:35 AM.

Details

Summary

This patch makes changes to attach function attributes to the following functions created in CGBlocks.cpp:

copy_helper_block_
destroy_helper_block_
Block_byref_object_copy_
Block_byref_object_dispose_

There are other places in clang where function attributes are not attached to functions. I plan to follow up with patches that fix those places too.

Diff Detail

Event Timeline

ahatanak updated this revision to Diff 36773.Oct 7 2015, 11:35 AM
ahatanak retitled this revision from to [CodeGen] Attach function attributes to functions created in CGBlocks.cpp..
ahatanak updated this object.
ahatanak added reviewers: dexonsmith, echristo.
ahatanak added a subscriber: cfe-commits.
ahatanak updated this revision to Diff 36886.Oct 8 2015, 11:56 AM

Changed CodeGenModule::SetLLVMFunctionAttributesForDefinition to use early return.

I'll first commit the NFC patch to fix CodeGenModule::SetLLVMFunctionAttributesForDefinition and commit the rest after that.

This revision was automatically updated to reflect the committed changes.