This is an archive of the discontinued LLVM Phabricator instance.

Add SafeStack support for test-suite.
AcceptedPublic

Authored by tharvik on Oct 6 2015, 3:04 AM.

Details

Reviewers
jroelofs

Diff Detail

Event Timeline

tharvik updated this revision to Diff 36606.Oct 6 2015, 3:04 AM
tharvik retitled this revision from to Add SafeStack support for test-suite..
tharvik updated this object.
tharvik updated this revision to Diff 36607.Oct 6 2015, 3:08 AM

Remove SafeStack from new-delete feature.

When running the test suite, it gives a bunch of undefined reference to '__safestack_unsafe_stack_ptr'.
See regression results.

jroelofs accepted this revision.Oct 6 2015, 9:11 AM
jroelofs added a reviewer: jroelofs.
jroelofs added a subscriber: cfe-commits.
jroelofs added a subscriber: jroelofs.

LGTM

This revision is now accepted and ready to land.Oct 6 2015, 9:11 AM

When running the test suite, it gives a bunch of undefined reference to '__safestack_unsafe_stack_ptr'.
See regression results.

Sounds like it's missing the safestack runtime, which should be provided by building compiler-rt.

When running the test suite, it gives a bunch of undefined reference to '__safestack_unsafe_stack_ptr'.
See regression results.

Sounds like it's missing the safestack runtime, which should be provided by building compiler-rt.

If you try to build compiler-rt, with safestack forced, you end up with some "already define" error, because safestack use interception which is needed by some tests. We can make these tests as excepted failure though.