lld: Allow -soname arg in addition to -soname=arg

[emaste]

Summary

Not documented, but GNU ld also accepts -soname arg. This is used by the FreeBSD build.

[emaste]

It turns out GNU ld also accepts --soname arg and --soname=arg for a total of 5 different ways of spelling the option. Do we want those as well?

Also it seems my change is against the convention established here. Should it be:

def alias_soname : Separate<["-"], "h">, Alias<soname>;
def alias_snoame : Separate<["-"], "soname">, Alias<soname>;

[ruiu]

LGTM

We probably should name these aliases alias_<alias name> instead of alias_<aliased name> to avoid conflicts, but this patch looks good for now.

[emaste]

We probably should name these aliases alias_<alias name> instead of alias_<aliased name> to avoid conflicts

I'm happy to submit another review to swap them around.

but this patch looks good for now.

To be clear, do you mean as I first submitted it, or the change with doubled def alias_soname?

lld/trunk/ELF/Options.td

 def alias_Bstatic_non_shared: Flag<["-"], "non_shared">, Alias<Bstatic>;
 def alias_Bstatic_static: Flag<["-"], "static">, Alias<Bstatic>;
 def alias_L : Joined<["--"], "library-path=">, Alias<L>;
 def alias_discard_all: Flag<["-"], "x">, Alias<discard_all>;
 def alias_discard_locals: Flag<["-"], "X">, Alias<discard_locals>;
 def alias_entry : Separate<["-"], "e">, Alias<entry>;
 def alias_l : Joined<["--"], "library=">, Alias<l>;
 def alias_soname : Separate<["-"], "h">, Alias<soname>;
+def alias_snoame : Separate<["-"], "soname">, Alias<soname>;
 
 // Options listed below are silently ignored now.
 def O3 : Flag<["-"], "O3">;
 def as_needed : Flag<["--"], "as-needed">;
 def build_id : Flag<["--"], "build-id">;
 def eh_frame_hdr : Flag<["--"], "eh-frame-hdr">;
 def enable_new_dtags : Flag<["--"], "enable-new-dtags">;
 def end_group : Flag<["--"], "end-group">;