This is an archive of the discontinued LLVM Phabricator instance.

Differential D13281

[ARM] Add missing test for build attribute Tag_Advanced_SIMD_arch when targeting v8.1
ClosedPublic

Authored by labrinea on Sep 30 2015, 2:16 AM.

Details

Reviewers
rengolin
llvm-commits
Commits
rG057f0a68cc66: Added missing test for [ARM] AttributeParser. Check that build attribute…
rL249304: Added missing test for [ARM] AttributeParser. Check that build attribute
Summary

Missing test case for ARM AttributeParser.

Diff Detail

Repository
rL LLVM

Event Timeline

labrinea updated this revision to Diff 36076.Sep 30 2015, 2:16 AM
labrinea retitled this revision from to Add missing test for build attribute Tag_Advanced_SIMD_arch when targeting v8.1.
labrinea updated this object.
labrinea added reviewers: rengolin, llvm-commits.
Herald added a subscriber: aemerson. · View Herald TranscriptSep 30 2015, 2:16 AM
labrinea retitled this revision from Add missing test for build attribute Tag_Advanced_SIMD_arch when targeting v8.1 to [ARM] Add missing test for build attribute Tag_Advanced_SIMD_arch when targeting v8.1.Sep 30 2015, 2:18 AM
rengolin accepted this revision.Oct 2 2015, 11:02 AM
rengolin edited edge metadata.
This revision is now accepted and ready to land.Oct 2 2015, 11:02 AM
Closed by commit rL249304: Added missing test for [ARM] AttributeParser. Check that build attribute (authored by alelab01). · Explain WhyOct 5 2015, 5:15 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
trunk/
test/
tools/
llvm-readobj/
ARM/
7 lines
tools/
llvm-readobj/
2 lines

Diff 36504

llvm/trunk/test/tools/llvm-readobj/ARM/attribute-4.s

Show All 9 Lines
.eabi_attribute Tag_FP_arch, 4 .eabi_attribute Tag_FP_arch, 4
@CHECK: .eabi_attribute 10, 4 @CHECK: .eabi_attribute 10, 4
@CHECK-OBJ: Tag: 10 @CHECK-OBJ: Tag: 10
@CHECK-OBJ-NEXT: Value: 4 @CHECK-OBJ-NEXT: Value: 4
@CHECK-OBJ-NEXT: TagName: FP_arch @CHECK-OBJ-NEXT: TagName: FP_arch
@CHECK-OBJ-NEXT: Description: VFPv3-D16 @CHECK-OBJ-NEXT: Description: VFPv3-D16
.eabi_attribute Tag_Advanced_SIMD_arch, 4
@CHECK: .eabi_attribute 12, 4
@CHECK-OBJ: Tag: 12
@CHECK-OBJ-NEXT: Value: 4
@CHECK-OBJ-NEXT: TagName: Advanced_SIMD_arch
@CHECK-OBJ-NEXT: Description: ARMv8.1-a NEON
.eabi_attribute Tag_PCS_config, 4 .eabi_attribute Tag_PCS_config, 4
@CHECK: .eabi_attribute 13, 4 @CHECK: .eabi_attribute 13, 4
@CHECK-OBJ: Tag: 13 @CHECK-OBJ: Tag: 13
@CHECK-OBJ-NEXT: Value: 4 @CHECK-OBJ-NEXT: Value: 4
@CHECK-OBJ-NEXT: TagName: PCS_config @CHECK-OBJ-NEXT: TagName: PCS_config
@CHECK-OBJ-NEXT: Description: Palm OS 2004 @CHECK-OBJ-NEXT: Description: Palm OS 2004
.eabi_attribute Tag_ABI_PCS_wchar_t, 4 .eabi_attribute Tag_ABI_PCS_wchar_t, 4
Show All 34 Lines

llvm/trunk/tools/llvm-readobj/ARMAttributeParser.cpp

Show First 20 Lines • Show All 187 Lines • ▼ Show 20 Linesvoid ARMAttributeParser::WMMX_arch(AttrType Tag, const uint8_t *Data,
StringRef ValueDesc = StringRef ValueDesc =
(Value < array_lengthof(Strings)) ? Strings[Value] : nullptr; (Value < array_lengthof(Strings)) ? Strings[Value] : nullptr;
PrintAttribute(Tag, Value, ValueDesc); PrintAttribute(Tag, Value, ValueDesc);
} }
void ARMAttributeParser::Advanced_SIMD_arch(AttrType Tag, const uint8_t *Data, void ARMAttributeParser::Advanced_SIMD_arch(AttrType Tag, const uint8_t *Data,
uint32_t &Offset) { uint32_t &Offset) {
static const char *Strings[] = { static const char *Strings[] = {
"Not Permitted", "NEONv1", "NEONv2+FMA", "ARMv8-a NEON" "Not Permitted", "NEONv1", "NEONv2+FMA", "ARMv8-a NEON", "ARMv8.1-a NEON"
}; };
uint64_t Value = ParseInteger(Data, Offset); uint64_t Value = ParseInteger(Data, Offset);
StringRef ValueDesc = StringRef ValueDesc =
(Value < array_lengthof(Strings)) ? Strings[Value] : nullptr; (Value < array_lengthof(Strings)) ? Strings[Value] : nullptr;
PrintAttribute(Tag, Value, ValueDesc); PrintAttribute(Tag, Value, ValueDesc);
} }
▲ Show 20 Lines • Show All 461 Lines • Show Last 20 Lines