This is an archive of the discontinued LLVM Phabricator instance.

[clang-tidy] fix add_new_check.py
ClosedPublic

Authored by mgehre on Sep 29 2015, 2:20 PM.

Details

Summary

Before this check, I would get the following error:

Updating ./misc/CMakeLists.txt...
Creating ./misc/NoReinterpret_castCheck.h...
Creating ./misc/NoReinterpret_castCheck.cpp...
Updating ./misc/MiscTidyModule.cpp...
Creating ../test/clang-tidy/misc-no-reinterpret_cast.cpp...
Creating ../docs/clang-tidy/checks/misc-no-reinterpret_cast.rst...
Traceback (most recent call last):

File "./add_new_check.py", line 271, in <module>
  main()
File "./add_new_check.py", line 267, in main
  update_checks_list(module_path)
File "./add_new_check.py", line 220, in update_checks_list
  os.listdir('docs/clang-tidy/checks')))

OSError: [Errno 2] No such file or directory: 'docs/clang-tidy/checks'

Diff Detail

Repository
rL LLVM

Event Timeline

mgehre updated this revision to Diff 36037.Sep 29 2015, 2:20 PM
mgehre retitled this revision from to [clang-tidy] fix add_new_check.py.
mgehre updated this object.
alexfh accepted this revision.Sep 29 2015, 6:27 PM
alexfh edited edge metadata.

Looks good! Thank you!

Do you need me to submit the patch for you?

This revision is now accepted and ready to land.Sep 29 2015, 6:27 PM

Yes, please. Btw, I'm going to submit some diffs for clang-tidy checks (for
the CppCoreGuidelines). Which reviewers should I set on them?

Alexander Kornienko <alexfh@google.com> schrieb am Mi., 30. Sep. 2015 03:27:

alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.

Looks good! Thank you!

Do you need me to submit the patch for you?

http://reviews.llvm.org/D13272

This revision was automatically updated to reflect the committed changes.
alexfh edited edge metadata.Oct 1 2015, 2:25 AM
alexfh added a subscriber: cfe-commits.
alexfh added a comment.Oct 1 2015, 2:32 AM

Yes, please. Btw, I'm going to submit some diffs for clang-tidy checks (for
the CppCoreGuidelines). Which reviewers should I set on them?

Please always add me to the reviewers and cfe-commits to Subscribers. Also note, that in October I'll be mostly unavailable, but other clang-tidy contributors can do the review and help getting patches in: sbenza, bkramer, aaron.ballman.

Patches are always welcome ;)