This ports functionality from the clang_macho_embedded.mk platform makefile over to CMake.
Details
Details
Diff Detail
Diff Detail
Event Timeline
cmake/Modules/CompilerRTDarwinUtils.cmake | ||
---|---|---|
327 | Please make sure these changes will not leak out of this macro and affect further compilations. | |
382 | Ugh. It's better to provide a different global variable for macho_embedded libraries, relative to COMPILER_RT_OUTPUT_DIR. | |
cmake/config-ix.cmake | ||
395 ↗ | (On Diff #35908) | Just move these declarations to darwin_add_embedded_builtin_libraries: you already hardcode a lot of archs/flags etc. there. |
Comment Actions
Updates based on feedback from samsonov.
- Changed darwin_add_embedded_builtin_libraries to a function
- Created a setting for DARWIN_macho_embedded_LIBRARY_OUTPUT_DIR
- Moved macho_embedded archs and sysroot settings into the function
- Also fixed an issue with sysroot specification -- we should be setting an ios sysroot for arm architectures
Comment Actions
LGTM. It's probably out of the scope of the patch, but: do you set the correct dependencies that would ensure re-building of Apple builtins/macho_embedded runtimes whenever exlcudes/includes files are updated?
Please make sure these changes will not leak out of this macro and affect further compilations.