This is an archive of the discontinued LLVM Phabricator instance.

[CMake] Adjust the variables set by LLVMConfig.cmake
ClosedPublic

Authored by john.brawn on Sep 28 2015, 8:49 AM.

Details

Summary

When using LLVMConfig.cmake from an installed toolchain in order to build a loadable pass using add_llvm_loadable_module LLVM_ENABLE_PLUGINS and LLVM_PLUGIN_EXT must be set. Also make LLVM_DEFINITIONS be set to what it actually is.

Diff Detail

Repository
rL LLVM

Event Timeline

john.brawn updated this revision to Diff 35876.Sep 28 2015, 8:49 AM
john.brawn retitled this revision from to [CMake] Adjust the variables set by LLVMConfig.cmake.
john.brawn updated this object.
john.brawn set the repository for this revision to rL LLVM.
john.brawn added a subscriber: llvm-commits.
chapuni edited edge metadata.Sep 28 2015, 4:35 PM

It'd be good if we were going toward that our scripts would work without LLVMHandleOptions.cmake.

Are there any discussions about it?

It'd be good if we were going toward that our scripts would work without LLVMHandleOptions.cmake.

Are there any discussions about it?

I'm not sure what you mean by this? Building a loadable pass already doesn't require using HandleLLVMOptions.cmake. The only partial dependency there is that HandleLLVMOptions.cmake sets -std=c++11 in the CXXFLAGS and if you don't use HandleLLVMOptions.cmake then you have to do that manually, but that's it as far as I can tell.

chapuni accepted this revision.Sep 29 2015, 10:03 AM
chapuni edited edge metadata.

Okay, it'd be good direction.

This revision is now accepted and ready to land.Sep 29 2015, 10:03 AM
This revision was automatically updated to reflect the committed changes.