Page MenuHomePhabricator

Check for GLIBC before including execinfo.h
ClosedPublic

Authored by vkalintiris on Sep 21 2015, 6:07 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

vkalintiris retitled this revision from to Check for GLIBC before including execinfo.h.
vkalintiris updated this object.
vkalintiris added reviewers: clayborg, ovyalov.
vkalintiris added a subscriber: llvm-commits.
clayborg accepted this revision.Sep 21 2015, 9:33 AM
clayborg edited edge metadata.
This revision is now accepted and ready to land.Sep 21 2015, 9:33 AM
danalbert added inline comments.Sep 21 2015, 9:56 AM
source/Host/linux/Host.cpp
17 ↗(On Diff #35241)

The !defined(__ANDROID__) is redundant. Android is never glibc.

This revision was automatically updated to reflect the committed changes.
brucem added a subscriber: brucem.Sep 22 2015, 3:01 AM

I missed this the other day. I think this change isn't needed because we can (I think) just not include <execinfo.h> now. It was added to support Host::Backtrace using backtrace, but that code has changed and is no longer here.

I missed this the other day. I think this change isn't needed because we can (I think) just not include <execinfo.h> now. It was added to support Host::Backtrace using backtrace, but that code has changed and is no longer here.

I tested it and it compiles fine without execinfo.h (Mint distro). Should I go on and remove the header? I'll keep an eye on the buildbots just in case.

I think so. A removal sounds so much better than having an #ifdef. :)