Page MenuHomePhabricator

Add support for lldb config.h and detect ncurses' include path
AbandonedPublic

Authored by krytarowski on Sep 19 2015, 1:12 PM.

Details

Reviewers
joerg
Summary

This change is required to get proper ncurses handling on NetBSD.

Diff Detail

Repository
rL LLVM

Event Timeline

krytarowski retitled this revision from to Add support for lldb config.h and detect ncurses' include path.
krytarowski updated this object.
krytarowski added a reviewer: joerg.
krytarowski set the repository for this revision to rL LLVM.

This ncurses header is now the blocker for buildslave.

[2817/3214] Building CXX object tools/lldb/source/Core/CMakeFiles/lldbCore.dir/IOHandler.cpp.o
FAILED: /usr/bin/g++   -DGTEST_HAS_RTTI=0 -DHAVE_ROUND -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -fPIC -fvisibility-inlines-hidden -Wall -W -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wno-maybe-uninitialized -Wno-comment -std=c++11 -ffunction-sections -fdata-sections -Wno-deprecated-declarations -Wno-unknown-pragmas -Wno-deprecated-register -Wno-vla-extension  -fno-exceptions -fno-rtti -fPIC -fPIC  -DNDEBUG -Itools/lldb/source/Core -I/home/motus/build/build/llvm/tools/lldb/source/Core -I/home/motus/build/build/llvm/tools/lldb/include -Itools/lldb/include -Iinclude -I/home/motus/build/build/llvm/include -I/usr/pkg/include/python2.7 -I/home/motus/build/build/llvm/tools/lldb/../clang/include -Itools/lldb/../clang/include -I/home/motus/build/build/llvm/tools/lldb/source/.     -fno-exceptions -fno-rtti -MMD -MT tools/lldb/source/Core/CMakeFiles/lldbCore.dir/IOHandler.cpp.o -MF tools/lldb/source/Core/CMakeFiles/lldbCore.dir/IOHandler.cpp.o.d -o tools/lldb/source/Core/CMakeFiles/lldbCore.dir/IOHandler.cpp.o -c /home/motus/build/build/llvm/tools/lldb/source/Core/IOHandler.cpp
/home/motus/build/build/llvm/tools/lldb/source/Core/IOHandler.cpp:32:21: fatal error: ncurses.h: No such file or directory
 #include <ncurses.h>
                     ^
compilation terminated.
ninja: build stopped: subcommand failed.
program finished with exit code 1
elapsedTime=2238.962841

http://lab.llvm.org:8014/builders/lldb-amd64-ninja-netbsd7/builds/139/steps/ninja%20build%20local/logs/stdio

krytarowski abandoned this revision.Oct 23 2015, 7:19 PM

Closing. We are going for reuse of the NetBSD native curses(8) library.

The reason for it is limit of detecting ncurses on various systems. For example, Ubuntu ships with <curses.h> and linkage from <ncurses.h>, ncurses.h isn't detected by CMake. Detecting <curses.h> on NetBSD is reusing conflicting header from the host curses(8) and pkgsrc's ncurses library.