This is an archive of the discontinued LLVM Phabricator instance.

[clang-cl]: Don't warn on /bigobj flag
ClosedPublic

Authored by thakis on Sep 18 2015, 1:15 PM.

Details

Reviewers
hans
Summary

LLVM r217812 made it so that clang-cl implicitly creates bigobj files when needed, independent of this flag. It looks like cl has this flag to produce obj flags compatible with MSVS 2003's linker by default, something we don't care about. Since clang-cl always has /bigobj behavior, don't warn that the flag is unused, just ignore it silently.

Diff Detail

Event Timeline

thakis updated this revision to Diff 35128.Sep 18 2015, 1:15 PM
thakis retitled this revision from to [clang-cl]: Don't warn on /bigobj flag.
thakis updated this object.
thakis added a reviewer: hans.
thakis added a subscriber: cfe-commits.
hans accepted this revision.Sep 18 2015, 1:36 PM
hans edited edge metadata.

LGTM

Please also add this to the tests for ignored options in test/Driver/cl-options.c:221

This revision is now accepted and ready to land.Sep 18 2015, 1:36 PM
thakis closed this revision.Sep 18 2015, 1:51 PM

r248034, thanks! (with test)