Page MenuHomePhabricator

[lldb-server] No need to add pthread twice.
ClosedPublic

Authored by dsanders on Sep 18 2015, 7:36 AM.

Details

Summary

Following on from r247991:
pthread is in LLDB_SYSTEM_LIBS so there's no need to explicitly add it to the link.

Diff Detail

Repository
rL LLVM

Event Timeline

dsanders updated this revision to Diff 35085.Sep 18 2015, 7:36 AM
dsanders updated this revision to Diff 35086.
dsanders retitled this revision from to [lldb-server] No need to add pthread twice..
dsanders updated this object.
dsanders added subscribers: krytarowski, labath, lldb-commits.

Correct the patch. Arcanist created the diff based on a revision prior to r247991 for some reason.

labath accepted this revision.Sep 21 2015, 8:13 AM
labath added a reviewer: labath.
This revision is now accepted and ready to land.Sep 21 2015, 8:13 AM

Thanks. I've acquired a new link failure (this time on lldb-mi) since my last build so I'll commit this once I have a temporary fix in place for that and can run the tests again.

'ninja clean' seems to have made the lldb-mi link failure go away. Presumably something didn't rebuild when the references to llvm_regcomp and llvm_regfree were added.

I'll run the lldb tests and then commit this.

This revision was automatically updated to reflect the committed changes.