GVN small fix

[Prazek]

Summary

Under the if (Dep.isClobber()) there was another if (Dep.isClobber())

[vsk]

It doesn't look like the conditional you've deleted is nested within the first "Dep.isClobber()" block.

[Prazek]

The if starts at 1855 and ends at 1942 right? So it ends just before new if with the sem operand

[Prazek]

It only makes sense if Dep could be changed in the previous if, but I don't see it is changed, and tests neither

[vsk]

Oh sorry! This looks fine.

[• dberlin]

Yeah, this looks right, and fixes some confusing logic.
Please commit it.

lib/Transforms/Scalar/GVN.cpp

if (AvailVal) {
       // Replace the load!
       L->replaceAllUsesWith(AvailVal);
       if (AvailVal->getType()->getScalarType()->isPointerTy())
         MD->invalidateCachedPointerInfo(AvailVal);
       markInstructionForDeletion(L);
       ++NumGVNLoad;
       return true;
     }
-  }
 
     // If the value isn't available, don't do anything!
-  if (Dep.isClobber()) {
     DEBUG(
       // fast print dep, using operator<< on instruction is too slow.
       dbgs() << "GVN: load ";
       L->printAsOperand(dbgs());
       Instruction *I = Dep.getInst();
       dbgs() << " is clobbered by " << *I << '\n';
     );
     return false;