Page MenuHomePhabricator

Improve the arm/aarch64 mapping symbol handling
ClosedPublic

Authored by tberghammer on Sep 10 2015, 6:29 AM.

Details

Summary

Improve the arm/aarch64 mapping symbol handling

Change the mapping symbol handling to handle the case when the mapping
symbols are prefixed with an arbitrary prefix. This isn't strictly standard
compliance, but if all symbols in an object file is prefixed with objcopy
then the prefix will be added to the mapping symbol also. We still want to
treat these symbols as mapping symbols to get the correct address class data.

Diff Detail

Repository
rL LLVM

Event Timeline

tberghammer retitled this revision from to Improve the arm/aarch64 mapping symbol handling.
tberghammer updated this object.
tberghammer added a reviewer: clayborg.
tberghammer added a subscriber: lldb-commits.
clayborg accepted this revision.Sep 10 2015, 10:02 AM
clayborg edited edge metadata.

Looks good.

This revision is now accepted and ready to land.Sep 10 2015, 10:02 AM
sas accepted this revision.Sep 10 2015, 11:28 AM
sas added a reviewer: sas.
sas added a subscriber: sas.
sas added inline comments.
source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
1857 ↗(On Diff #34432)

Not very important, but maping vs mapping.

This revision was automatically updated to reflect the committed changes.
tberghammer marked an inline comment as done.